Ukrainian localization is added #6542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davorpa
added
the
waiting for changes
This comment has been minimized.
This comment has been minimized.
davorpa
reviewed
Oct 31, 2021
HOWTO-fr.md
Outdated
Comment on lines
7
to
13
| * [Youtube - Comment Fork un Repo GitHub et Soumettre une Pull Request](https://www.youtube.com/watch?v=G1I3HF4YWEw) | ||
| * [Youtube - Comment Fork un Repo GitHub et Soumettre un Pull Request](https://www.youtube.com/watch?v=G1I3HF4YWEw) | ||
| * [Youtube - Tutoriel Github pour debutant](https://www.youtube.com/watch?v=0fKg7e37bQE) | ||
|
|
||
|
|
||
| N'hésitez pas à poser des questions; chaque contributeur a commencé par une première PR. Vous pourriez être notre millième! | ||
| N'hésitez pas à poser des questions; chaque contributeur a commencé par un premier PR. Vous pourriez être notre millième! | ||
|
|
||
| Même si vous êtes un contributeur open source expérimenté, il y a des choses qui peuvent vous faire trébucher. Une fois que vous avez soumis votre PR, GitHub Actions exécutera un linter, trouvant souvent de petits problèmes d'espacement ou d'alphabétisation. Si vous obtenez un bouton vert, tout est prêt pour l'examen, mais sinon, cliquez sur "Détails" sous la vérification qui n'a pas réussi pour découvrir ce que le linter n'a pas aimé. Résolvez le problème et ajoutez un commit à votre PR. | ||
| Même si vous êtes un contributeur open source expérimenté, il y a des choses qui peuvent vous trébucher. Une fois que vous avez soumis votre PR, GitHub Actions exécutera un linter, trouvant souvent de petits problèmes d'espacement ou d'alphabétisation. Si vous obtenez un bouton vert, tout est prêt pour l'examen, mais sinon, cliquez sur "Détails" sous la vérification qui n'a pas réussi à découvrir ce que le linter n'a pas aimé. Résolvez le problème et ajoutez un commit à votre PR. |
There was a problem hiding this comment.
Why? Try to don't oversecope contributions
Resolved by 89b0cba
davorpa
added
the
👀 Needs Review
|
@eshellman, Locale for Ukrainian is |
davorpa
removed
the
👀 Needs Review
davorpa
requested changes
Oct 31, 2021
| @@ -1,4 +1,4 @@ | |||
| إقرأ هذا بلغات أخرى: [English](HOWTO.md), [Français](HOWTO-fr.md), [Español](HOWTO-es.md), [简体中文](HOWTO-zh.md), [हिन्दी](HOWTO-hi.md), [繁體中文](HOWTO-zh_TW.md), [Português (BR)](HOWTO-pt_BR.md), [فارسی](HOWTO-fa_IR.md), [Русский](HOWTO-ru.md), [Deutsch](HOWTO-de.md), [Bahasa Indonesia](HOWTO-id.md), [Українська](HOWTO-uk_UA.md). | |||
| إقرأ هذا بلغات أخرى: [English](HOWTO.md), [Français](HOWTO-fr.md), [Español](HOWTO-es.md), [简体中文](HOWTO-zh.md), [हिन्दी](HOWTO-hi.md), [繁體中文](HOWTO-zh_TW.md), [Português (BR)](HOWTO-pt_BR.md), [فارسی](HOWTO-fa_IR.md), [Русский](HOWTO-ru.md), [Deutsch](HOWTO-de.md), [Bahasa Indonesia](HOWTO-id.md), [Українська](HOWTO-uk.md). | |||
There was a problem hiding this comment.
With the intention of avoiding merge conflicts in other pending PRs, I'm in favour of avoid this kind of crosslinks in all changed files. Try to scope to -uk files.
There was a problem hiding this comment.
@davorpa In any case you will need to add those references in other files. Wouldn't it be better to do it right now?
|
@eshellman files were renamed |
|
Thanks, and welcome to free-programming-books! |
This was referenced Nov 1, 2021
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add resource(s) | Remove resource(s) | Add info | Improve repo
For resources
Description
Why is this valuable (or not)?
Ukrainian language is added
How do we know it's really free?
For book lists, is it a book? For course lists, is it a course? etc.
Checklist:
Follow-up