Skip to content

Fix stale workflow #11865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 18, 2025
Merged

Fix stale workflow #11865

merged 4 commits into from
Apr 18, 2025

Conversation

Thenlie
Copy link
Contributor

@Thenlie Thenlie commented Apr 17, 2025

What does this PR do?

Improve repo

For resources

Description

The stale workflow was not working quite right. It would label PR's as stale, but not close them after they remained stale. This PR modernizes the stale workflow and should fix this issue.

Explanation

  • Workflow will run once per day at midnight
  • If a PR is not updated for 60 days, it will be marked as stale
  • If a stale PR is not updated for 30 days, it will be closed
  • The workflow can also be kicked off manually and be run normally, or in debug mode (dry run)
  • The timings are not changed from before

Docs

The action is well documented at https://github.com/actions/stale

Checklist:

  • Read our contributing guidelines.
  • Search for duplicates.
  • Include author(s) and platform where appropriate.
  • Put lists in alphabetical order, correct spacing.
  • Add needed indications (PDF, access notes, under construction).
  • Used an informative name for this pull request.

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

@Thenlie
Copy link
Contributor Author

Thenlie commented Apr 17, 2025

Important

I have not been able to properly test this workflow, still brainstorming the best process to do that.

@Thenlie Thenlie requested a review from eshellman April 17, 2025 22:19
INPUT_ISSUES: ${{ steps.stale-issues.outputs.closed-issues-prs }}
INPUT_PRS: ${{ steps.stale-prs.outputs.closed-issues-prs }}

- name: Write job summary
Copy link
Contributor Author

@Thenlie Thenlie Apr 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stale action already has a summary built in. We just need to set ACTIONS_STEP_DEBUG to true in the repo settings.

https://github.com/actions/stale#debugging

@eshellman eshellman merged commit 4f0f6b7 into EbookFoundation:main Apr 18, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants