Skip to content

Pin ddtrace to <v4. #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2025
Merged

Pin ddtrace to <v4. #563

merged 1 commit into from
Mar 7, 2025

Conversation

purple4reina
Copy link
Contributor

What does this PR do?

Motivation

Testing Guidelines

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@purple4reina purple4reina requested a review from a team as a code owner February 25, 2025 20:45
@kimmoahokas
Copy link

Should this currently pin the version to <3? Taking https://github.com/DataDog/dd-trace-py/releases/tag/v3.0.0 looks like a bigger change here. Just interested because we had just a small incident where we took dd-trace-py in use in custom instrumentation, but that broke because we wrapped the function with datadog-lambda-python that requires v2.

@purple4reina
Copy link
Contributor Author

Should this currently pin the version to <3? Taking DataDog/dd-trace-py@v3.0.0 (release) looks like a bigger change here. Just interested because we had just a small incident where we took dd-trace-py in use in custom instrumentation, but that broke because we wrapped the function with datadog-lambda-python that requires v2.

The most recent version of the datadog-lambda-python package now supports v3.0 of ddtrace. I suspect that you were using an older version of datadog-lambda-python that did not yet support v3.0 of ddtrace, which caused your incident.

joeyzhao2018
joeyzhao2018 approved these changes Mar 3, 2025
View reviewed changes
Copy link
Contributor

@joeyzhao2018 joeyzhao2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@purple4reina purple4reina force-pushed the purple4reina-patch-1 branch from e431231 to 4a07c26 Compare March 7, 2025 17:52
@purple4reina purple4reina requested a review from a team as a code owner March 7, 2025 17:52
duncanista
duncanista reviewed Mar 7, 2025
View reviewed changes
pyproject.toml
@@ -28,7 +28,7 @@ classifiers = [
python = ">=3.8.0,<4"
datadog = ">=0.51.0,<1.0.0"
wrapt = "^1.11.2"
ddtrace = ">=2.20.0"
ddtrace = ">=2.20.0,<4"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we are covering two major versions here, 2.2 and 3, is this intended?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. For now we are supporting both.

duncanista
duncanista approved these changes Mar 7, 2025
View reviewed changes
Copy link
Contributor

@duncanista duncanista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving assuming both major versions have been tested by @DataDog/apm-serverless

@purple4reina purple4reina merged commit fc0beaa into main Mar 7, 2025
59 checks passed
@purple4reina purple4reina deleted the purple4reina-patch-1 branch March 7, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeyzhao2018 joeyzhao2018 joeyzhao2018 approved these changes

@duncanista duncanista duncanista approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@purple4reina @kimmoahokas @joeyzhao2018 @duncanista