Re-remove iast .so file. #560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit DataDog/dd-trace-py@fa18def was merged to address this.
|
Reduces layer size |
purple4reina
force-pushed
the
rey.abolofia/rm-so
branch
from
b2ffab6 to
edae4ad
Compare
hghotra
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit DataDog/dd-trace-py@fa18def was merged to address this.
What does this PR do?
Re-removes the
ddtrace/appsec/_iast/_stacktrace*.sofile from our python layers.Motivation
A change was made by the appsec team to the python tracer which inadvertently caused an import attempt on
ddtrace/appsec/_iast/_stacktrace*.so. This import would fail when using our python layer. We remove this file because it is large and iast doesn't work in serverless anyway.I worked with the appsec team directly to address this. They came up with a solution that not only ensures we don't import
ddtrace/appsec/_iast/_stacktrace*.so, but also makes sure no iast code is imported when iast is disabled.Now that DataDog/dd-trace-py#12212 is merged, we can go back to safely removing this .so file in our layers.
Testing Guidelines
I have another PR open to the python agent (DataDog/dd-trace-py#11888) which will add explicit testing to ensure none of our removed files get imported.
Additional Notes
Note that the mentioned PR is merged but not yet released! Do not merge this until that PR has been released!
Types of Changes
Check all that apply