Skip to content

upgrade(deps): bump minimum ddtrace version to v2.20.0 #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 30, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion datadog_lambda/cold_start.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ def set_cold_start(init_timestamp_ns):
_cold_start = False
_proactive_initialization = False
_lambda_container_initialized = True
from ddtrace import tracer as _tracer
from ddtrace.trace import tracer as _tracer


def is_cold_start():
Expand Down
4 changes: 2 additions & 2 deletions datadog_lambda/tracing.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,10 @@
parse_xray_header,
)

from ddtrace import tracer, patch, Span
from ddtrace import patch
from ddtrace import __version__ as ddtrace_version
from ddtrace.propagation.http import HTTPPropagator
from ddtrace.context import Context
from ddtrace.trace import Context, Span, tracer
from datadog_lambda import __version__ as datadog_lambda_version
from datadog_lambda.trigger import (
_EventSource,
Expand Down
2 changes: 1 addition & 1 deletion tests/test_benchmarks.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def test_metric_write_metric_point_to_stdout(benchmark, monkeypatch):
def test_tag_object_tag_object(event, benchmark):
with open(f"{event_samples_dir}/{event}.json") as f:
event = json.load(f)
span = ddtrace.tracer.start_span("test")
span = ddtrace.trace.tracer.start_span("test")
benchmark(tag_object.tag_object, span, "function.request", event)


Expand Down
7 changes: 3 additions & 4 deletions tests/test_tracing.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,7 @@

import ddtrace

from ddtrace import tracer
from ddtrace.context import Context
from ddtrace.trace import Context, tracer
from ddtrace._trace._span_pointer import _SpanPointer
from ddtrace._trace._span_pointer import _SpanPointerDirection
from ddtrace._trace._span_pointer import _SpanPointerDescription
Expand Down Expand Up @@ -2158,7 +2157,7 @@ def __init__(self, service, start, span_type, parent_name=None, tags=None):


@pytest.mark.parametrize("source,expect", _test_create_inferred_span)
@patch("ddtrace.Span.finish", autospec=True)
@patch("ddtrace.trace.Span.finish", autospec=True)
def test_create_inferred_span(mock_span_finish, source, expect):
with open(f"{event_samples}{source}.json") as f:
event = json.load(f)
Expand Down Expand Up @@ -2197,7 +2196,7 @@ def test_mark_trace_as_error_for_5xx_responses_getting_400_response_code(
def test_mark_trace_as_error_for_5xx_responses_sends_error_metric_and_set_error_tags(
self, mock_submit_errors_metric
):
mock_span = Mock(ddtrace.Span)
mock_span = Mock(ddtrace.trace.Span)
status_code = "500"
mark_trace_as_error_for_5xx_responses(
context="fake_context", status_code=status_code, span=mock_span
Expand Down
2 changes: 1 addition & 1 deletion tests/test_wrapper.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
import datadog_lambda.xray as xray
from datadog_lambda.metric import lambda_metric
from datadog_lambda.thread_stats_writer import ThreadStatsWriter
from ddtrace import Span, tracer
from ddtrace.trace import Span, tracer
from ddtrace.internal.constants import MAX_UINT_64BITS

from tests.utils import get_mock_context, reset_xray_connection
Expand Down
Loading