Skip to content

chore: simplified GovCloud release script #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

apiarian-datadog
Copy link
Contributor

What does this PR do?

Adds a flag to the prod release script to simplify it for GovCloud releases.

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@apiarian-datadog apiarian-datadog requested a review from a team as a code owner November 6, 2024 16:06
@apiarian-datadog
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 6, 2024

🚂 MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!

@dd-devflow
Copy link

dd-devflow bot commented Nov 6, 2024

⚠️ MergeQueue: This merge request was unqueued

This merge request was unqueued

If you need support, contact us on Slack #devflow!

Copy link

@alexgallotta alexgallotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to break it down in functions to reduce the duplicate code and make it more readable?

@apiarian-datadog
Copy link
Contributor Author

Is it possible to break it down in functions to reduce the duplicate code and make it more readable?

probably, but that sounds like a different refactor. also, it's a bash script and time spent refacotring is probably better used actually building govcloud release automation instead.

@apiarian-datadog apiarian-datadog merged commit 57d1a81 into main Nov 14, 2024
51 of 52 checks passed
@apiarian-datadog apiarian-datadog deleted the aleksandr.pasechnik/simplified-govcloud-release branch November 14, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants