Use single socket instance for all xray api calls. #467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
purple4reina
commented
Apr 9, 2024
datadog_lambda/xray.py
Outdated
| except Exception as e_send: | ||
| logger.error("Error occurred submitting to xray daemon: %s", e_send) | ||
|
|
||
| def reset(self): |
There was a problem hiding this comment.
reset is used for tests.
There was a problem hiding this comment.
nitpick: can we move it to tests files?
There was a problem hiding this comment.
Yes, good call. Done.
purple4reina
commented
Apr 9, 2024
| self._host_port_tuple = self._get_xray_host_port( | ||
| os.environ.get(XrayDaemon.XRAY_DAEMON_ADDRESS, "") | ||
| ) | ||
| return self._host_port_tuple |
There was a problem hiding this comment.
This value is now memoized so we only need to parse the env var once.
purple4reina
commented
Apr 9, 2024
| @@ -623,7 +626,7 @@ def handler(event, context): | |||
| self.assertEqual(result.span_id, aws_lambda_span.span_id) | |||
| self.assertEqual(result.sampling_priority, 1) | |||
| mock_send.assert_called_once() | |||
| (_, raw_payload), _ = mock_send.call_args | |||
| (raw_payload,), _ = mock_send.call_args | |||
There was a problem hiding this comment.
Signature of the xray.send method changed.
|
Confirmed metadata is still being sent to the xray api. |
joeyzhao2018
approved these changes
Apr 9, 2024
datadog_lambda/xray.py
Outdated
| except Exception as e_send: | ||
| logger.error("Error occurred submitting to xray daemon: %s", e_send) | ||
|
|
||
| def reset(self): |
There was a problem hiding this comment.
nitpick: can we move it to tests files?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
The need for speed.
Testing Guidelines
Additional Notes
Previously, we were creating a new socket connection and closing the connection for each xray api call. When xray is enabled, and the lambda has extracted trace context from an upstream event, the xray api is called twice.
When an xray api is called, this change decreases runtime duration by somewhere between 1-5%.
Types of Changes
Check all that apply