Skip to content

Reduce allocations during event parsing. #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 5, 2024
Merged

Reduce allocations during event parsing. #463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0969236
Reduce allocations during event parsing.
purple4reina Apr 2, 2024
7d1753f
Simplify SQS/SNS data extraction logic.
purple4reina Apr 4, 2024
87242a8
Update snapshots.
purple4reina Apr 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
323 changes: 149 additions & 174 deletions datadog_lambda/tracing.py
View file
Open in desktop

Large diffs are not rendered by default.

68 changes: 34 additions & 34 deletions tests/integration/snapshots/logs/async-metrics_python310.log
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,11 +67,11 @@ HTTP GET https://www.datadoghq.com/ Headers: ["Accept-Encoding:gzip, deflate", "
"_inferred_span.tag_source": "self",
"http.status_code": "200",
"peer.service": "integration-tests-python",
"_dd.peer.service.source": "peer.service",
"_dd.base_service": "integration-tests-python",
"_dd.p.dm": "-0",
"_dd.p.tid": "XXXX",
"language": "python",
"_dd.peer.service.source": "peer.service",
"_dd.base_service": "integration-tests-python"
"language": "python"
},
"metrics": {
"process_id": XXXX,
Expand Down Expand Up @@ -237,16 +237,16 @@ HTTP GET https://www.datadoghq.com/ Headers: ["Accept-Encoding:gzip, deflate", "
"_inferred_span.synchronicity": "async",
"_inferred_span.tag_source": "self",
"peer.service": "integration-tests-python",
"_dd.peer.service.source": "peer.service",
"_dd.base_service": "integration-tests-python",
"_dd.p.dm": "-0",
"_dd.p.tid": "XXXX",
"language": "python",
"_dd.peer.service.source": "peer.service",
"_dd.base_service": "integration-tests-python"
"language": "python"
},
"metrics": {
"process_id": XXXX,
"_dd.top_level": 1,
"_sampling_priority_v1": 1
"_sampling_priority_v1": -1
},
"type": "web"
},
Expand Down Expand Up @@ -397,11 +397,11 @@ HTTP GET https://www.datadoghq.com/ Headers: ["Accept-Encoding:gzip, deflate", "
"_inferred_span.synchronicity": "async",
"_inferred_span.tag_source": "self",
"peer.service": "integration-tests-python",
"_dd.peer.service.source": "peer.service",
"_dd.base_service": "integration-tests-python",
"_dd.p.dm": "-0",
"_dd.p.tid": "XXXX",
"language": "python",
"_dd.peer.service.source": "peer.service",
"_dd.base_service": "integration-tests-python"
"language": "python"
},
"metrics": {
"process_id": XXXX,
Expand Down Expand Up @@ -566,16 +566,16 @@ HTTP GET https://www.datadoghq.com/ Headers: ["Accept-Encoding:gzip, deflate", "
"_inferred_span.tag_source": "self",
"http.status_code": "200",
"peer.service": "integration-tests-python",
"_dd.peer.service.source": "peer.service",
"_dd.base_service": "integration-tests-python",
"_dd.p.dm": "-0",
"_dd.p.tid": "XXXX",
"language": "python",
"_dd.peer.service.source": "peer.service",
"_dd.base_service": "integration-tests-python"
"language": "python"
},
"metrics": {
"process_id": XXXX,
"_dd.top_level": 1,
"_sampling_priority_v1": 1
"_sampling_priority_v1": -1
},
"type": "http"
},
Expand Down Expand Up @@ -736,16 +736,16 @@ HTTP GET https://www.datadoghq.com/ Headers: ["Accept-Encoding:gzip, deflate", "
"_inferred_span.synchronicity": "async",
"_inferred_span.tag_source": "self",
"peer.service": "integration-tests-python",
"_dd.peer.service.source": "peer.service",
"_dd.base_service": "integration-tests-python",
"_dd.p.dm": "-0",
"_dd.p.tid": "XXXX",
"language": "python",
"_dd.peer.service.source": "peer.service",
"_dd.base_service": "integration-tests-python"
"language": "python"
},
"metrics": {
"process_id": XXXX,
"_dd.top_level": 1,
"_sampling_priority_v1": 1
"_sampling_priority_v1": -1
},
"type": "web"
},
Expand Down Expand Up @@ -899,16 +899,16 @@ HTTP GET https://www.datadoghq.com/ Headers: ["Accept-Encoding:gzip, deflate", "
"_inferred_span.synchronicity": "async",
"_inferred_span.tag_source": "self",
"peer.service": "integration-tests-python",
"_dd.peer.service.source": "peer.service",
"_dd.base_service": "integration-tests-python",
"_dd.p.dm": "-0",
"_dd.p.tid": "XXXX",
"language": "python",
"_dd.peer.service.source": "peer.service",
"_dd.base_service": "integration-tests-python"
"language": "python"
},
"metrics": {
"process_id": XXXX,
"_dd.top_level": 1,
"_sampling_priority_v1": 1
"_sampling_priority_v1": -1
},
"type": "web"
},
Expand Down Expand Up @@ -1063,16 +1063,16 @@ HTTP GET https://www.datadoghq.com/ Headers: ["Accept-Encoding:gzip, deflate", "
"_inferred_span.synchronicity": "async",
"_inferred_span.tag_source": "self",
"peer.service": "integration-tests-python",
"_dd.peer.service.source": "peer.service",
"_dd.base_service": "integration-tests-python",
"_dd.p.dm": "-0",
"_dd.p.tid": "XXXX",
"language": "python",
"_dd.peer.service.source": "peer.service",
"_dd.base_service": "integration-tests-python"
"language": "python"
},
"metrics": {
"process_id": XXXX,
"_dd.top_level": 1,
"_sampling_priority_v1": 1
"_sampling_priority_v1": -1
},
"type": "web"
},
Expand Down Expand Up @@ -1226,16 +1226,16 @@ HTTP GET https://www.datadoghq.com/ Headers: ["Accept-Encoding:gzip, deflate", "
"_inferred_span.synchronicity": "async",
"_inferred_span.tag_source": "self",
"peer.service": "integration-tests-python",
"_dd.peer.service.source": "peer.service",
"_dd.base_service": "integration-tests-python",
"_dd.p.dm": "-0",
"_dd.p.tid": "XXXX",
"language": "python",
"_dd.peer.service.source": "peer.service",
"_dd.base_service": "integration-tests-python"
"language": "python"
},
"metrics": {
"process_id": XXXX,
"_dd.top_level": 1,
"_sampling_priority_v1": 1
"_sampling_priority_v1": -1
},
"type": "web"
},
Expand Down Expand Up @@ -1395,16 +1395,16 @@ HTTP GET https://www.datadoghq.com/ Headers: ["Accept-Encoding:gzip, deflate", "
"_inferred_span.tag_source": "self",
"http.status_code": "200",
"peer.service": "integration-tests-python",
"_dd.peer.service.source": "peer.service",
"_dd.base_service": "integration-tests-python",
"_dd.p.dm": "-0",
"_dd.p.tid": "XXXX",
"language": "python",
"_dd.peer.service.source": "peer.service",
"_dd.base_service": "integration-tests-python"
"language": "python"
},
"metrics": {
"process_id": XXXX,
"_dd.top_level": 1,
"_sampling_priority_v1": 1
"_sampling_priority_v1": -1
},
"type": "web"
},
Expand Down
70 changes: 35 additions & 35 deletions tests/integration/snapshots/logs/async-metrics_python311.log
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,11 +67,11 @@ HTTP GET https://www.datadoghq.com/ Headers: ["Accept-Encoding:gzip, deflate", "
"_inferred_span.tag_source": "self",
"http.status_code": "200",
"peer.service": "integration-tests-python",
"_dd.peer.service.source": "peer.service",
"_dd.base_service": "integration-tests-python",
"_dd.p.dm": "-0",
"_dd.p.tid": "XXXX",
"language": "python",
"_dd.peer.service.source": "peer.service",
"_dd.base_service": "integration-tests-python"
"language": "python"
},
"metrics": {
"process_id": XXXX,
Expand Down Expand Up @@ -237,16 +237,16 @@ HTTP GET https://www.datadoghq.com/ Headers: ["Accept-Encoding:gzip, deflate", "
"_inferred_span.synchronicity": "async",
"_inferred_span.tag_source": "self",
"peer.service": "integration-tests-python",
"_dd.peer.service.source": "peer.service",
"_dd.base_service": "integration-tests-python",
"_dd.p.dm": "-0",
"_dd.p.tid": "XXXX",
"language": "python",
"_dd.peer.service.source": "peer.service",
"_dd.base_service": "integration-tests-python"
"language": "python"
},
"metrics": {
"process_id": XXXX,
"_dd.top_level": 1,
"_sampling_priority_v1": 1
"_sampling_priority_v1": -1
},
"type": "web"
},
Expand Down Expand Up @@ -397,11 +397,11 @@ HTTP GET https://www.datadoghq.com/ Headers: ["Accept-Encoding:gzip, deflate", "
"_inferred_span.synchronicity": "async",
"_inferred_span.tag_source": "self",
"peer.service": "integration-tests-python",
"_dd.peer.service.source": "peer.service",
"_dd.base_service": "integration-tests-python",
"_dd.p.dm": "-0",
"_dd.p.tid": "XXXX",
"language": "python",
"_dd.peer.service.source": "peer.service",
"_dd.base_service": "integration-tests-python"
"language": "python"
},
"metrics": {
"process_id": XXXX,
Expand Down Expand Up @@ -566,16 +566,16 @@ HTTP GET https://www.datadoghq.com/ Headers: ["Accept-Encoding:gzip, deflate", "
"_inferred_span.tag_source": "self",
"http.status_code": "200",
"peer.service": "integration-tests-python",
"_dd.peer.service.source": "peer.service",
"_dd.base_service": "integration-tests-python",
"_dd.p.dm": "-0",
"_dd.p.tid": "XXXX",
"language": "python",
"_dd.peer.service.source": "peer.service",
"_dd.base_service": "integration-tests-python"
"language": "python"
},
"metrics": {
"process_id": XXXX,
"_dd.top_level": 1,
"_sampling_priority_v1": 1
"_sampling_priority_v1": -1
},
"type": "http"
},
Expand Down Expand Up @@ -708,6 +708,7 @@ START
}
HTTP GET https://datadoghq.com/ Headers: ["Accept-Encoding:gzip, deflate", "Accept:*/*", "Connection:keep-alive", "User-Agent:python-requests/X.X.X", "traceparent:XXX", "tracestate:XXX
HTTP GET https://www.datadoghq.com/ Headers: ["Accept-Encoding:gzip, deflate", "Accept:*/*", "Connection:keep-alive", "User-Agent:python-requests/X.X.X", "traceparent:XXX", "tracestate:XXX
END Duration: XXXX ms Memory Used: XXXX MB
{
"traces": [
[
Expand Down Expand Up @@ -736,16 +737,16 @@ HTTP GET https://www.datadoghq.com/ Headers: ["Accept-Encoding:gzip, deflate", "
"_inferred_span.synchronicity": "async",
"_inferred_span.tag_source": "self",
"peer.service": "integration-tests-python",
"_dd.peer.service.source": "peer.service",
"_dd.base_service": "integration-tests-python",
"_dd.p.dm": "-0",
"_dd.p.tid": "XXXX",
"language": "python",
"_dd.peer.service.source": "peer.service",
"_dd.base_service": "integration-tests-python"
"language": "python"
},
"metrics": {
"process_id": XXXX,
"_dd.top_level": 1,
"_sampling_priority_v1": 1
"_sampling_priority_v1": -1
},
"type": "web"
},
Expand Down Expand Up @@ -834,7 +835,6 @@ HTTP GET https://www.datadoghq.com/ Headers: ["Accept-Encoding:gzip, deflate", "
]
]
}
END Duration: XXXX ms Memory Used: XXXX MB
START
{
"m": "aws.lambda.enhanced.invocations",
Expand Down Expand Up @@ -899,16 +899,16 @@ HTTP GET https://www.datadoghq.com/ Headers: ["Accept-Encoding:gzip, deflate", "
"_inferred_span.synchronicity": "async",
"_inferred_span.tag_source": "self",
"peer.service": "integration-tests-python",
"_dd.peer.service.source": "peer.service",
"_dd.base_service": "integration-tests-python",
"_dd.p.dm": "-0",
"_dd.p.tid": "XXXX",
"language": "python",
"_dd.peer.service.source": "peer.service",
"_dd.base_service": "integration-tests-python"
"language": "python"
},
"metrics": {
"process_id": XXXX,
"_dd.top_level": 1,
"_sampling_priority_v1": 1
"_sampling_priority_v1": -1
},
"type": "web"
},
Expand Down Expand Up @@ -1063,16 +1063,16 @@ HTTP GET https://www.datadoghq.com/ Headers: ["Accept-Encoding:gzip, deflate", "
"_inferred_span.synchronicity": "async",
"_inferred_span.tag_source": "self",
"peer.service": "integration-tests-python",
"_dd.peer.service.source": "peer.service",
"_dd.base_service": "integration-tests-python",
"_dd.p.dm": "-0",
"_dd.p.tid": "XXXX",
"language": "python",
"_dd.peer.service.source": "peer.service",
"_dd.base_service": "integration-tests-python"
"language": "python"
},
"metrics": {
"process_id": XXXX,
"_dd.top_level": 1,
"_sampling_priority_v1": 1
"_sampling_priority_v1": -1
},
"type": "web"
},
Expand Down Expand Up @@ -1226,16 +1226,16 @@ HTTP GET https://www.datadoghq.com/ Headers: ["Accept-Encoding:gzip, deflate", "
"_inferred_span.synchronicity": "async",
"_inferred_span.tag_source": "self",
"peer.service": "integration-tests-python",
"_dd.peer.service.source": "peer.service",
"_dd.base_service": "integration-tests-python",
"_dd.p.dm": "-0",
"_dd.p.tid": "XXXX",
"language": "python",
"_dd.peer.service.source": "peer.service",
"_dd.base_service": "integration-tests-python"
"language": "python"
},
"metrics": {
"process_id": XXXX,
"_dd.top_level": 1,
"_sampling_priority_v1": 1
"_sampling_priority_v1": -1
},
"type": "web"
},
Expand Down Expand Up @@ -1395,16 +1395,16 @@ HTTP GET https://www.datadoghq.com/ Headers: ["Accept-Encoding:gzip, deflate", "
"_inferred_span.tag_source": "self",
"http.status_code": "200",
"peer.service": "integration-tests-python",
"_dd.peer.service.source": "peer.service",
"_dd.base_service": "integration-tests-python",
"_dd.p.dm": "-0",
"_dd.p.tid": "XXXX",
"language": "python",
"_dd.peer.service.source": "peer.service",
"_dd.base_service": "integration-tests-python"
"language": "python"
},
"metrics": {
"process_id": XXXX,
"_dd.top_level": 1,
"_sampling_priority_v1": 1
"_sampling_priority_v1": -1
},
"type": "web"
},
Expand Down
Loading
Loading