Fixes error where app module fails to load in testing #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bsouthga Ready for review. I've included checkboxes on the PR to test on your machine. |
kanhirun
changed the title
kanhirun
changed the title
|
Hey kel, thanks for the PR! really appreciate your detailed description of the issue + your fix. I merged in a travis hook to test this with our CI setup and it seems to fail (as there is no headless chrome available, the one advantage of Phantom) -- any thoughts on a fix for this? We would love to keep the ability to run the automated tests if possible. |
kanhirun
force-pushed
the
fixes_ng_module_error
branch
from
2f0ebba to
a813859
Compare
New Changes@bsouthga I've added two commits recently:
Additional Testing
I'll look into configuring TravisCI for running Chrome. Thanks for bringing this up. 👍 |
kanhirun
force-pushed
the
fixes_ng_module_error
branch
2 times, most recently
from
57389ff to
6a3c5e0
Compare
|
@bsouthga 🎱 says that it's now passing. I squashed those changes on |
When calling `module()` with `inject()`, an error is thrown: ``` Error: [$injector:modulerr] Failed to instantiate module ng due to: TypeError: 'undefined' is not an object (evaluating 'Function.prototype.bind.apply') ``` PhantomJS is not amongst Karma's officially supported browsers. In 1.x, `Function.prototype.bind` isn't defined. Instead of polyfilling, or using Phantom 2.x, it is better to stick with supported browsers. (In addition, TravisCI has been reconfigured to run Chrome.) READ MORE: http://blog.500tech.com/setting-up-travis-ci-to-run-tests-on-latest-google-chrome-version/
The matcher, `toThrowError()` is valid only in Jasmine, and not Mocha. Managing multiple competing test frameworks is not ideal. Therefore, I have configured all karma config files to use Jasmine only.
kanhirun
force-pushed
the
fixes_ng_module_error
branch
from
6a3c5e0 to
8ae6684
Compare
|
Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Tasks
git push origin --delete fixes_ng_module_error_phantomjs_upgradeTesting
./node_modules/.bin/gulp test-src. Is the test passing?