Skip to content

Turn JSHint back on for src files #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yangchristian opened this issue Oct 27, 2015 · 0 comments
Closed

Turn JSHint back on for src files #1

yangchristian opened this issue Oct 27, 2015 · 0 comments
Assignees
@yangchristian
Labels
enhancement

Comments

@yangchristian
Copy link
Member

Currently turned off due to /* jshint ignore:start */ not working in the latest available JSHint release (jshint/jshint#2411).

We're using ignore because we're more-or-less directly pasting in the Zendesk widget embed code. Otherwise, we'd have to format their minified JS.
@yangchristian yangchristian self-assigned this Oct 27, 2015
kanhirun added a commit that referenced this issue May 31, 2016
@kanhirun
Re-enables javascript linting with ESLint
28b07e2 
Fixes #1
@kanhirun kanhirun mentioned this issue May 31, 2016
Merged
bsouthga added a commit that referenced this issue May 31, 2016
@bsouthga
Merge pull request #2 from CrossLead/reenable_jslint_on_src_files
2a2a031 
Fixes Issue #1: Re-enables JS linting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yangchristian yangchristian

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yangchristian