Catches errors in flow_script and sets status (in execution_status table) #429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to 'error'. This allows another job to be run (which could not happen if status was left as 'executing'. Needs UI support (Issue #336)
If status = 'error', the details field contains the traceback
|
27a7194 writes the traceback to the database execution_status.details column for the job : |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to 'error'. This allows another job to be run (which could not happen if exception was not caught and status was left as 'executing').
Needs UI support (Issue #336 , #229 ) Note that admin_api.py/execute() will return a useful status back to React. We need to check it and tell the user something useful. If there was an error, retrying probably won't help but it should be reported.
Closes #228