Mults ratio trade off #51
Conversation
|
@RitwikC07 There is a merge commit in your PR, in VTR we don't allow merge commits instead you should rebase with master. |
parmys/optimal_ratio.txt
Outdated
There was a problem hiding this comment.
What is the purpose of this file? Can this be handled using default variables by adding its related section to the config file?
parmys/dt.py
Outdated
There was a problem hiding this comment.
Check for other methods of transferring the ration instead of using a text file explicitly.
parmys/dt_saved.joblib
Outdated
There was a problem hiding this comment.
Please consider coming up with a better structure instead of putting model files inside root of Parmys directory.
There was a problem hiding this comment.
Please consider using the libraries already present in the VTR codebase for the file IO.
There was a problem hiding this comment.
Please consider removing extra libs e.g. 'fstream' and 'iostream' and use 'stdio.h' instead for codebase uniformity
Description
Machine learning model was trained on data set collected by running vtr task. This model was integrated into the VTR pipeline and the result of input to the model i.e. the optimal multiplier ratio was sent to partial mapper to carry out required changes.
Related Issue
Added a new feature of integrating machine learning model for hard/soft logic trade offs in VTR
Motivation and Context
This change adds intelligence to the VTR pipeline and helps to perform hard/soft logic trade offs.
How Has This Been Tested?
The complete vtr_flow was ran and log files were checked to see if the changes makes sense and are working fine
Types of changes
Checklist: