Skip to content

Drop GRPC message size limitation #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 17, 2020
Merged

Drop GRPC message size limitation #632

merged 7 commits into from
Mar 17, 2020

Conversation

Hazhzeng
Copy link
Contributor

@Hazhzeng Hazhzeng commented Mar 16, 2020

Background

To allow GRPC passing large message (e.g. large files) between worker and host.

Fixes

Resolves: #628

Documents

GRPC_ARG_MAX_RECEIVE_MESSAGE_LENGTH = -1 docs

GRPC_ARG_MAX_SEND_MESSAGE_LENGTH = -1 docs

Miscellaneous

Fix build pipeline to support the latest host version

@Hazhzeng Hazhzeng requested a review from pragnagopa March 16, 2020 17:55
Copy link
Member

@pragnagopa pragnagopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good. Please do take a look at the test failures for this PR. It is possible this change could have caused failures.

@Hazhzeng Hazhzeng changed the title Increase message size to sys.maxsize Drop GRPC message size limitation Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove max message size limit on gRpc channel
3 participants