Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build: recognize collection_model_binding_data for batch inputs #1655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: recognize collection_model_binding_data for batch inputs #1655
Changes from all commits
733cc4e
07c8a49
2c758e3
b913fec
47ef15a
c5ca0fe
f4d8590
0206ddd
9b88194
5359b17
1274e03
6e5b6ca
ab2a745
f695391
d92ae90
797534c
c4a29d3
83fc793
e991156
6ee6a91
c0235e9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: Improvement suggestion:
validSources = {
"AzureEventHubsEventData",
"AzureServiceBusReceivedMessage"
}
if datum.type == "collection_model_binding_data" or datum.value.source in valid_sources:
return binding.decode(datum, trigger_metadata=metadata, pytype=pytype)
Also, can type can be enum in your datum model? That will avoid the string comparisons and improve the codebae as less strings constant will flow.