Skip to content

style: Isortifying the repo and adding pyproject.toml #1526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 11, 2024

Conversation

vrdmr
Copy link
Member

@vrdmr vrdmr commented Jul 7, 2024

Description

Adding Isort for the repo and adding configuration.

  • Removed the isort.cfg in favor of PyProject.toml file
  • Isorted the complete azure_functions_worker and test module. Made minor changes in the sort order and skipped protos.

Fixes #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

.isort.cfg Outdated
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for isort specific config, using pyproject.toml to set these settings.

from .tracecontext import TraceContext
from .retrycontext import RetryContext
from .retrycontext import RetryContext # isort: skip
from .tracecontext import TraceContext # isort: skip
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skipping these two for preventing cyclic import issue when importing from .context import Context

@gavin-aguiar gavin-aguiar merged commit f01ea13 into dev Jul 11, 2024
5 of 15 checks passed
@gavin-aguiar gavin-aguiar deleted the vameru/isortifying branch July 11, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants