-
Notifications
You must be signed in to change notification settings - Fork 107
feat: OpenTelemetry support #1469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4a185b8
to
07bf3eb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1469 +/- ##
===========================================
- Coverage 84.64% 46.16% -38.49%
===========================================
Files 35 36 +1
Lines 2052 2307 +255
Branches 387 433 +46
===========================================
- Hits 1737 1065 -672
- Misses 232 1157 +925
- Partials 83 85 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Description
Added support for opentelemetry.
The worker does not take a dependency on opentelemetry but checks if the function app has opentelemetry. If it finds the libraries, it will setup the Otel configs needed.
Otel is configured separately for sync and async. For async functions, we can directly call
configure_opentelemetry
but for sync functions this method has to be called inside the ThreadPool executor which is used to run sync functions.This is because OpenTelemetry is thread specific and will only update the Span on the thread it is configured
Sample function app.
Fixes #
PR information
Quality of Code and Contribution Guidelines