Skip to content

Moving function indexing to init request #1446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Mar 25, 2024
Merged

Conversation

gavin-aguiar
Copy link
Contributor

@gavin-aguiar gavin-aguiar commented Mar 12, 2024

Description

Included in this PR:

  • In the dispatcher, indexing is moved from metadata request to init request and env reload request and results are stored and returned in the metadata response
  • Indexing in init is behind an flag: ENABLE_INIT_INDEXING
  • Unit tests, e2e tests and consumption tests

Fixes #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 85.30%. Comparing base (c68f88b) to head (916ffb2).

Files Patch % Lines
azure_functions_worker/dispatcher.py 92.30% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1446      +/-   ##
==========================================
+ Coverage   85.10%   85.30%   +0.19%     
==========================================
  Files          35       35              
  Lines        1974     1987      +13     
  Branches      374      379       +5     
==========================================
+ Hits         1680     1695      +15     
+ Misses        218      216       -2     
  Partials       76       76              
Flag Coverage Δ
unittests 85.25% <92.85%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gavin-aguiar gavin-aguiar marked this pull request as draft March 12, 2024 20:57
@gavin-aguiar gavin-aguiar marked this pull request as ready for review March 13, 2024 18:31
@YunchuWang YunchuWang self-requested a review March 15, 2024 21:05
@YunchuWang YunchuWang requested a review from hallvictoria March 15, 2024 21:07
@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 82.05128% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 85.23%. Comparing base (c68f88b) to head (18d6231).

Files Patch % Lines
azure_functions_worker/dispatcher.py 81.08% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1446      +/-   ##
==========================================
+ Coverage   85.10%   85.23%   +0.12%     
==========================================
  Files          35       35              
  Lines        1974     1998      +24     
  Branches      374      378       +4     
==========================================
+ Hits         1680     1703      +23     
- Misses        218      219       +1     
  Partials       76       76              
Flag Coverage Δ
unittests 85.18% <82.05%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@vrdmr vrdmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gavin-aguiar gavin-aguiar merged commit 8ebd94e into dev Mar 25, 2024
49 checks passed
@gavin-aguiar gavin-aguiar deleted the gaaguiar/init_refactoring branch March 25, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants