-
Notifications
You must be signed in to change notification settings - Fork 107
Enabled implicit output for generic bindings #1391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabled implicit output for generic bindings #1391
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1391 +/- ##
==========================================
+ Coverage 85.19% 85.61% +0.42%
==========================================
Files 35 35
Lines 1965 1974 +9
Branches 370 374 +4
==========================================
+ Hits 1674 1690 +16
+ Misses 217 213 -4
+ Partials 74 71 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/profile |
…/github.com/Azure/azure-functions-python-worker into hallvictoria/enable_generic_implicit_output
…-worker into hallvictoria/enable_generic_implicit_output
…/github.com/Azure/azure-functions-python-worker into hallvictoria/enable_generic_implicit_output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Description
Enables implicit output for generic types. This addresses an ask from the Logic Apps team for generic type bindings to have implicit return.
In implementing this, two main errors occurred:
FunctionLoadError: cannot load the DurableFunctionsHttpStart1 function: Python return annotation "HttpResponse" does not match binding type "durableClient"
"TypeError: unable to encode outgoing TypedData: unsupported type "<class 'azure_functions_worker.bindings.generic.GenericBinding'>" for Python type "HttpResponse"
"-The boolean will be set to true and prevent the return type from later being overwritten
-The $return return type will overwrite the implicit output binding return type
-The return type will be set to that of the implicit output binding
Fixes #
PR information
Quality of Code and Contribution Guidelines