Skip to content

Add activity trigger encode/decode logic for durable function #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 9, 2020

Conversation

Hazhzeng
Copy link
Contributor

@Hazhzeng Hazhzeng commented Apr 2, 2020

Dependency

Azure/azure-functions-python-worker#643

Background

Previously, the Activity Trigger in Python Durable Functions only supports string as return value. Now, we should support JSON serializable Python primitive types.

✔string, int, float, bool, list of string/int/float/bool, dictionary of string/int/float/bool, None
❌set, frozenset, bytes, bytearray, custom type, custom dataclass

@Hazhzeng Hazhzeng requested a review from vrdmr April 2, 2020 19:09
Copy link
Contributor

@davidmrdavid davidmrdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes seem reasonable but I'm not an active owner of this repo so I would like someone else to also approve before merging. Also, please review my comment below.

@Hazhzeng Hazhzeng requested a review from ankitkumarr April 7, 2020 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants