-
Notifications
You must be signed in to change notification settings - Fork 68
Add ServiceBus inteface definition #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can you add the test code as well? I need to look at how this is being used |
Test code is in the worker repo. These are abstract definitions. |
import typing | ||
|
||
|
||
class ServiceBusMessage(abc.ABC): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Azure Functions supports ServiceBusQueues and ServiceBusTopics. Add ServiceBusTopicMessage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do topics and queues actually receive different data? The binding documentation mentions only that the parameter type may receive instances of Message
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@asavaritayal - Can you look into this and confirm if we need different types for queue message and topic?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need different types. function.json
should take care of the exact source.
import typing | ||
|
||
|
||
class ServiceBusMessage(abc.ABC): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename to ServiceBusQueueMessage
No description provided.