Skip to content

Add ServiceBus inteface definition #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2018
Merged

Add ServiceBus inteface definition #2

merged 1 commit into from
Jul 3, 2018

Conversation

elprans
Copy link
Collaborator

@elprans elprans commented Jun 26, 2018

No description provided.

@elprans elprans requested a review from pragnagopa June 26, 2018 18:14
@pragnagopa
Copy link
Member

Can you add the test code as well? I need to look at how this is being used

@elprans
Copy link
Collaborator Author

elprans commented Jun 26, 2018

Test code is in the worker repo. These are abstract definitions.

import typing


class ServiceBusMessage(abc.ABC):
Copy link
Member

@pragnagopa pragnagopa Jun 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Azure Functions supports ServiceBusQueues and ServiceBusTopics. Add ServiceBusTopicMessage

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do topics and queues actually receive different data? The binding documentation mentions only that the parameter type may receive instances of Message

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asavaritayal - Can you look into this and confirm if we need different types for queue message and topic?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need different types. function.json should take care of the exact source.

import typing


class ServiceBusMessage(abc.ABC):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename to ServiceBusQueueMessage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants