-
Notifications
You must be signed in to change notification settings - Fork 69
ASGI lifecycle events #187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 25 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
a2ad67c
Yield a disconnect on the second receive call
tonybaloney d8fc213
Merge remote-tracking branch 'upstream/dev' into dev
tonybaloney b9cd37a
Merge branch 'Azure:dev' into dev
tonybaloney ad52ad5
Merge remote-tracking branch 'upstream/dev' into dev
tonybaloney e6c925c
Integrate ASGI startup and shutdown lifecycle events
tonybaloney be4dffd
Merge branch 'dev' into asgi_startup_lifecycles
tonybaloney 734e2ac
Code cleanup
tonybaloney 2083a48
Support startup and shutdown events. Capture failures. Use asyncio ev…
tonybaloney be386e5
Use debug
tonybaloney 1efb812
Lint code and fix some tests
tonybaloney fc1f829
Run the shutdown as a task
tonybaloney 1c8b7de
Use a type variable for the receive queue
tonybaloney ee1fadd
Direct imports
tonybaloney fb457ec
Initialize event loops
tonybaloney ca836de
Initialize queues and signals inside coroutines to ensure the same ev…
tonybaloney 502b2ca
Test all sequences and events
tonybaloney 246afd2
Verify sequence runtime error is thrown
tonybaloney c88123e
Check startup was called before calling destroy in __del__ magic
tonybaloney d4788fe
Will no longer execute requests if the startup failed, will retry.
tonybaloney 60ae50f
Test more failure scenarios
tonybaloney d86c622
Merge branch 'dev' into asgi_startup_lifecycles
tonybaloney fe58fdf
Merge branch 'dev' into asgi_startup_lifecycles
tonybaloney 7c129cf
Merge branch 'dev' into asgi_startup_lifecycles
tonybaloney 1b88383
Merge branch 'dev' into asgi_startup_lifecycles
gavin-aguiar b94205a
Merge branch 'dev' into asgi_startup_lifecycles
tonybaloney 8113f1b
Merge branch 'dev' into asgi_startup_lifecycles
vrdmr f083cf8
Merge branch 'dev' into asgi_startup_lifecycles
gavin-aguiar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curious why for shutdown, we dont raise runtimeerror if shutdown does not succeed (similar to startup)?