-
Notifications
You must be signed in to change notification settings - Fork 53
Move to packaging everything in contentFiles with added nuspec #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
185c616
move to packaging everything in contentFiles with added nuspec
TylerLeonhardt 91b67bb
update README with package steps
TylerLeonhardt 82882bb
changed / to \ because WIndows needs it but *nix doesn't care
TylerLeonhardt 97d01bd
switched icon url and used utf-8 with bom
TylerLeonhardt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 16 additions & 0 deletions
16
package/Microsoft.Azure.Functions.PowerShellWorker.Package.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
<!-- | ||
Copyright (c) Microsoft. All rights reserved. | ||
Licensed under the MIT license. See LICENSE file in the project root for full license information. | ||
--> | ||
<Project Sdk="Microsoft.NET.Sdk"> | ||
<PropertyGroup> | ||
<TargetFramework>netcoreapp2.1</TargetFramework> | ||
<NoBuild>true</NoBuild> | ||
<IncludeBuildOutput>false</IncludeBuildOutput> | ||
<TreatWarningsAsErrors>true</TreatWarningsAsErrors> | ||
<NoWarn>NU5100;NU5123</NoWarn> | ||
|
||
<NuspecFile>Microsoft.Azure.Functions.PowerShellWorker.nuspec</NuspecFile> | ||
<NuspecProperties>configuration=$(Configuration);targetFramework=$(TargetFramework)</NuspecProperties> | ||
</PropertyGroup> | ||
</Project> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
<?xml version="1.0" encoding="utf-8"?> | ||
<!-- | ||
Copyright (c) Microsoft. All rights reserved. | ||
Licensed under the MIT license. See LICENSE file in the project root for full license information. | ||
--> | ||
<package xmlns="http://schemas.microsoft.com/packaging/2013/05/nuspec.xsd"> | ||
<metadata> | ||
<id>Microsoft.Azure.Functions.PowerShellWorker</id> | ||
<version>0.1.0</version> | ||
<title>Azure Function PowerShell Language Worker</title> | ||
<authors>Microsoft</authors> | ||
<owners>Microsoft</owners> | ||
<requireLicenseAcceptance>false</requireLicenseAcceptance> | ||
<licenseUrl>https://github.com/Azure/azure-functions-powershell-worker/blob/dev/LICENSE</licenseUrl> | ||
<projectUrl>https://github.com/Azure/azure-functions-powershell-worker</projectUrl> | ||
<iconUrl>https://github.com/PowerShell/PowerShell/blob/master/assets/Powershell_64.png</iconUrl> | ||
<description>The Azure Function PowerShell Language Worker allows users to write Azure Function Apps using PowerShell. It leverages the PowerShell Core SDK.</description> | ||
<releaseNotes># 0.1.0 | ||
|
||
Initial Release</releaseNotes> | ||
<copyright>© Microsoft Corporation. All rights reserved.</copyright> | ||
<tags>azure,functions,powershell,worker</tags> | ||
<contentFiles> | ||
<files include="**\*" buildAction="None" copyToOutput="true" flatten="false"/> | ||
</contentFiles> | ||
</metadata> | ||
<files> | ||
<file src="..\src\bin\$configuration$\$targetFramework$\publish\**\*" target="contentFiles\any\any\workers\powershell" /> | ||
</files> | ||
</package> |
25 changes: 0 additions & 25 deletions
25
src/Microsoft.Azure.Functions.PowerShellWorker.Package.props
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Observed 2 issues with the produced package:
iconUrl
used inSystem.Management.Automation
is<iconUrl>https://github.com/PowerShell/PowerShell/blob/master/assets/Powershell_black_64.png?raw=true</iconUrl>
. Its icon shows up fine.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I addressed both of these. Can you test it out for me really quick if it's easy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p.s. the file was expected to be in
UTF-8 with BOM