Skip to content

Nugetize #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 5, 2018
Merged

Nugetize #26

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ce2fb51
update configs for beta36 of core tools and add windows if check
Aug 31, 2018
71c3317
add a comment to explain why execution policy is needed
Aug 31, 2018
70b7a47
Merge branch 'dev' of github.com:Azure/azure-functions-powershell-wor…
Sep 1, 2018
746fe76
nugetize the worker
Sep 1, 2018
fd4e340
Assert.Equal to Assert.Single
TylerLeonhardt Sep 1, 2018
79cc631
Added PackageCopyToOutput
TylerLeonhardt Sep 4, 2018
ac0655f
Add new line at end
daxian-dbw Sep 4, 2018
72a9e7c
added Product
TylerLeonhardt Sep 5, 2018
4146d28
Merge branch 'nugetize' of github.com:Azure/azure-functions-powershel…
TylerLeonhardt Sep 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions src/Azure.Functions.PowerShell.Worker.Package.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
<!--
Copyright (c) Microsoft. All rights reserved.
Licensed under the MIT license. See LICENSE file in the project root for full license information.
-->
<Project>
<PropertyGroup>
<Version>0.1.0</Version>
<PackageId>Azure.Functions.PowerShell.Worker</PackageId>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we do the renaming (from Azure.Functions.PowerShell.Worker to Microsoft.Azure.Functions.PowerShellWorker) in this repo before publishing NuGet package?

Not necessarily be done in this PR. I think it's better to do it after merging this PR.

Copy link
Member Author

@TylerLeonhardt TylerLeonhardt Sep 5, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I agree. We should see what the other language workers are called and try to be consistent.

<Authors>Microsoft</Authors>
<Owners>Microsoft</Owners>
<Company>Microsoft Corporation</Company>
<Description>The Azure Function PowerShell Language Worker allows users to write Azure Function Apps using PowerShell. It leverages the PowerShell Core SDK.</Description>
<Title>Azure Function PowerShell Language Worker</Title>
<Copyright>© Microsoft Corporation. All rights reserved.</Copyright>
<PackageLicenseUrl>https://github.com/Azure/azure-functions-powershell-worker/blob/dev/LICENSE</PackageLicenseUrl>
<PackageProjectUrl>https://github.com/Azure/azure-functions-powershell-worker</PackageProjectUrl>
<PackageIconUrl>https://github.com/PowerShell/PowerShell/blob/master/assets/Powershell_64.png</PackageIconUrl>
<PackageTags>azure,functions,powershell,worker</PackageTags>
<PackageReleaseNotes>
# 0.1.0

Initial Release
</PackageReleaseNotes>
</PropertyGroup>
</Project>
22 changes: 12 additions & 10 deletions src/Azure.Functions.PowerShell.Worker.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,18 @@
<!--
Copyright (c) Microsoft. All rights reserved.
Licensed under the MIT license. See LICENSE file in the project root for full license information.
-->
<Project Sdk="Microsoft.NET.Sdk">

<Import Project="Azure.Functions.PowerShell.Worker.Package.props" />
<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>netcoreapp2.1</TargetFramework>
<Product>Azure Function PowerShell Language Worker</Product>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<Company> and <CopyRight> tags are included in the package.props, but the <Product> tag probably should be kept?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added.

<Company>Microsoft Corporation</Company>
<Copyright>(c) Microsoft Corporation. All rights reserved.</Copyright>

<TargetFramework>netcoreapp2.1</TargetFramework>
<LangVersion>Latest</LangVersion>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<AllowUnsafeBlocks>false</AllowUnsafeBlocks>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
<IncludeBuildOutput>true</IncludeBuildOutput>
<SuppressNETCoreSdkPreviewMessage>true</SuppressNETCoreSdkPreviewMessage>
<NeutralLanguage>en-US</NeutralLanguage>
</PropertyGroup>
Expand All @@ -24,13 +26,13 @@
</ItemGroup>

<ItemGroup>
<None Include="worker.config.json">
<Content Include="worker.config.json" PackageCopyToOutput="true">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
<None Include="Modules\**">
</Content>
<Content Include="Modules\**" PackageCopyToOutput="true">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!! 💯

<Link>Modules\%(RecursiveDir)\%(FileName)%(Extension)</Link>
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
</Content>
</ItemGroup>

</Project>
2 changes: 1 addition & 1 deletion test/Function/FunctionLoaderTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ public void TestFunctionLoaderGetInfo()
Assert.Equal(directory, funcInfo.Directory);
Assert.Equal(name, funcInfo.FunctionName);
Assert.Equal(2, funcInfo.AllBindings.Count);
Assert.Equal(1, funcInfo.OutBindings.Count);
Assert.Single(funcInfo.OutputBindings);
}
}
}