Scan all .deps.json files and determine root project #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Looks good, thank you! |
justinyoo
requested changes
Aug 30, 2021
There was a problem hiding this comment.
@vincentbitter Thanks for your contribution!
Can you also add this to Microsoft.Azure.WebJobs.Extensions.OpenApi/OpenApiHttpTriggerContext.cs so that in-proc extension also get this updated?
src/Microsoft.Azure.Functions.Worker.Extensions.OpenApi/OpenApiHttpTriggerContext.cs
Outdated
Show resolved
Hide resolved
Good idea, I've added it! |
justinyoo
approved these changes
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #172
Fixes #122
If other projects are referenced in a function app, the output folder can contain multiple .deps.json files.
With this PR, all .deps.json files will be scanned for dependencies on other projects. Based on that information, the root project can be determined.