Skip to content

update to idweb 2.16.0 #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 30, 2023
Merged

update to idweb 2.16.0 #743

merged 5 commits into from
Nov 30, 2023

Conversation

kllysng
Copy link
Contributor

@kllysng kllysng commented Nov 27, 2023

No description provided.

@kllysng kllysng requested a review from jennyf19 November 27, 2023 22:09
brentschmaltz
brentschmaltz requested changes Nov 28, 2023
View reviewed changes
Copy link

@brentschmaltz brentschmaltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a define somewhere so changes can be made in one place.

@jennyf19
Copy link
Contributor

Have a define somewhere so changes can be made in one place.

would rather not do that, as this is a sample for customers and we have readmes per sample. So having things stand-alone in the csproj is easier for customers to consume and understand.

jennyf19
jennyf19 requested changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as this is a sample, please revert back to previous thanks.

@kllysng kllysng requested a review from jennyf19 November 28, 2023 19:49
jmprieur
jmprieur approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @kellyyangsong

@kllysng kllysng merged commit 9e67d5b into master Nov 30, 2023
@kllysng kllysng deleted the kellysong/idweb2.16.0 branch November 30, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmprieur jmprieur jmprieur approved these changes

@brentschmaltz brentschmaltz Awaiting requested review from brentschmaltz

@jennyf19 jennyf19 Awaiting requested review from jennyf19

Assignees
No one assigned
Labels
merge after ms identity web release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kllysng @jennyf19 @brentschmaltz @jmprieur