bug fixes and minor edits #73
Conversation
There was a problem hiding this comment.
@kalyankrishna1 : this is mostly good.
A couple of typos, things to change.
A question.
| @@ -127,9 +127,10 @@ Function ConfigureApplications | |||
|
|
|||
|
|
|||
| # Update config file for 'webApp' | |||
| $commonendpoint = "common" | |||
There was a problem hiding this comment.
What is the point, @kalyankrishna1 ?
also this is not an endpoint? more a peuso-tenant? #Resolved
There was a problem hiding this comment.
unless I do this, running the powershell script would not place this value in the appsettings.json. Tried a few approaches, this finally seemed to work. I was surprised , but well this worked.
In reply to: 272026301 [](ancestors = 272026301)
There was a problem hiding this comment.
Do we need to update the code generator @kalyankrishna1 ?
|
|
||
|  | ||
|
|
||
| > This is the first phase of a set of tutorials. Once you understand how to sign-in users in an ASP.NET Core Web App with Open Id Connect, can can learn how to enable your [Web App to call a Web API on behalf of the signed-in user](../../2-WebApp-graph-user) | ||
| > This is the first chapter of a set of tutorials. Once you understand how to sign-in users in an ASP.NET Core Web App with Open Id Connect, can can learn how to enable your [Web App to call a Web API on behalf of the signed-in user](../../2-WebApp-graph-user) |
There was a problem hiding this comment.
excellent. that's the word I was looking for! #Resolved
| > Tip: If you register your apps with the scripts, to get directly to the app registration portal page for a give app, you can navigate to the links provided in the [AppCreationScripts\createdApps.html](AppCreationScripts\createdApps.html). This file is generated by the scripts during the app registration and configuration. | ||
|
|
||
| 4. Open the Visual Studio solution and click start. That's it! | ||
| 4. Once you've run the script, please ensure that you've followedthe following manual steps. Azure AD PowerShell does not yet create an app whose audience is `Work or School + personal accounts`. This audience setting is possible from the Azure portal: |
There was a problem hiding this comment.
there is a typo (follwedthe) #Resolved
| - search for **signInAudience** and make sure it's set to **AzureADandPersonalMicrosoftAccount** | ||
| - Select **Save** | ||
|
|
||
| > Tip: If you register your apps with the scripts, to get directly to the app registration portal page for a give app, you can navigate to the links provided in the [AppCreationScripts\createdApps.html](AppCreationScripts\createdApps.html). This file is generated by the scripts during the app registration and configuration. |
There was a problem hiding this comment.
| @@ -127,9 +127,10 @@ Function ConfigureApplications | |||
|
|
|||
|
|
|||
| # Update config file for 'webApp' | |||
| $commonendpoint = "common" | |||
There was a problem hiding this comment.
Do we need to update the code generator @kalyankrishna1 ?
Purpose
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
What to Check
Verify that the following are valid
Other Information