Skip to content

Updating Id Web version and fixing graphics bug #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 17, 2023

Conversation

JoshLozensky
Copy link
Contributor

@JoshLozensky JoshLozensky commented Aug 16, 2023

Updating Id Web version to 2.13.3 and fixing graphics bug

Summary of the changes (Less than 80 chars)
Update Id Web to 2.13.3, fix page layout rendering issue, and minor doc edits.

Description

Rendering issue was caused by a navbar format in the layout.cshtml files in several samples
Doc edits were to provide clarity and parity between the README and notes in the files themselves.
Update to Id Web version part of standard release process for the same version.

Fixes #724

@JoshLozensky JoshLozensky changed the title Lozensky/2.13.3 id web Updating Id Web version and fixing graphics bug Aug 16, 2023
Copy link
Contributor

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @JoshLozensky

@@ -22,7 +22,7 @@
- a scope corresponding to a V1 application (for instance <GUID>/user_impersonation, where <GUID> is the
clientId of a V1 application, created in the https://portal.azure.com portal.
*/
"TodoListServiceAppId": "[Enter_client_ID_Of_TodoListService-v2_from_Azure_Portal,_e.g._2ec40e65-ba09-4853-bcde-bcb60029e596",
"TodoListServiceAppId": "[Enter_client_ID_Of_TodoListService-v2_from_Azure_Portal,_e.g._2ec40e65-ba09-4853-bcde-bcb60029e596]",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

Copy link
Contributor

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@JoshLozensky JoshLozensky merged commit 9ddd69d into master Aug 17, 2023
@JoshLozensky JoshLozensky deleted the lozensky/2.13.3IdWeb branch August 17, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix graphic on 3-Web-app-multi-apis & 4-1
3 participants