-
Notifications
You must be signed in to change notification settings - Fork 1k
Jmprieur/folder renaming #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR applies Kalyan's suggestion. |
/1-WebApp-OIDC/1-6-SignOut/.vs | ||
/1-WebApp-OIDC/1-6-SignOut/bin | ||
/1-WebApp-OIDC/1-6-SignOut/obj | ||
/2-WebApp-graph-user/2-1-Call-MSGraph/.vs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can omit "Call", right? What other purpose a sample will have with Graph other than calling it :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep it.
/1-WebApp-OIDC/1-6-SignOut/obj | ||
/2-WebApp-graph-user/2-1-Call-MSGraph/.vs | ||
/2-WebApp-graph-user/2-1-Call-MSGraph/bin | ||
/2-WebApp-graph-user/2-1-Call-MSGraph/obj |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also save two letters by using just graph
instead of 'MSGraph. We only care about one graph now, so the
MS` prefix can be omitted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AAD Graph is still there and for a few years. We want to promote MSGraph, but let's avoid being ambiguous.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved with a few suggestions
Purpose
The folder names were too long and had spaces.
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test