Skip to content

Jmprieur/folder renaming #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 15, 2019
Merged

Jmprieur/folder renaming #61

merged 5 commits into from
Mar 15, 2019

Conversation

jmprieur
Copy link
Contributor

Purpose

The folder names were too long and had spaces.

  • Renamed them,
  • updated the README.md so that the links work
  • updated the .gitignore so that unwanted files are not proposed to staging

Does this introduce a breaking change?

[x ] Yes. Breaks links we would have previously shared. But this is preferable to do it now
[ ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
  • Test the code
Follow README.mds

@jmprieur jmprieur requested a review from kalyankrishna1 March 13, 2019 12:33
@jmprieur
Copy link
Contributor Author

This PR applies Kalyan's suggestion.
It's is pretty mechanical and should be easy to review

/1-WebApp-OIDC/1-6-SignOut/.vs
/1-WebApp-OIDC/1-6-SignOut/bin
/1-WebApp-OIDC/1-6-SignOut/obj
/2-WebApp-graph-user/2-1-Call-MSGraph/.vs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can omit "Call", right? What other purpose a sample will have with Graph other than calling it :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep it.

/1-WebApp-OIDC/1-6-SignOut/obj
/2-WebApp-graph-user/2-1-Call-MSGraph/.vs
/2-WebApp-graph-user/2-1-Call-MSGraph/bin
/2-WebApp-graph-user/2-1-Call-MSGraph/obj
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also save two letters by using just graph instead of 'MSGraph. We only care about one graph now, so the MS` prefix can be omitted

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AAD Graph is still there and for a few years. We want to promote MSGraph, but let's avoid being ambiguous.

Copy link
Contributor

@kalyankrishna1 kalyankrishna1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with a few suggestions

@jmprieur jmprieur merged commit b58c114 into tutorials Mar 15, 2019
@jmprieur jmprieur deleted the jmprieur/folderRenaming branch March 15, 2019 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants