-
Notifications
You must be signed in to change notification settings - Fork 1k
added package.json with specific versions as recommended by Git #569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @aremo-ms
Are you sure these are dependencies and not just devDependencies? Would shell.js be needed for a production build? |
Ideally it wouldn't matter because you're right it is just a sample but it's good hygiene. Looking at the bootstrap library referenced it seems that it is a devDependency and not a pure dependency. |
I'm fine to fix it, but I don't see markdown-it dependency for bootstrap. Ideas? |
Indeed. Much more annoying is I'm not seeing that dependency in any of the other jQuery libraries neither. Not sure where that's coming from. |
After giving it a second look it seems that dependabot is 'guessing' what those dependencies could be since the package.json file isn't there and is picking markdown-it as a possible library dependency. But I will need to confirm that. I'm not seeing anything here that uses that. |
I'm changing both to devDependencies |
LGTM |
Purpose
Added package.json under every wwwroot/lib/bootstrap as recommended by GitHub automation