Skip to content

Update 2-2-TokenCache #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 11, 2020

Conversation

damienbod
Copy link
Contributor

@damienbod damienbod commented Sep 5, 2020

Purpose

  • Update bootstrap 4, frontend packages, css
  • Update to latest Microsoft.Identity.Web C# templates
  • Update app settings
  • Update Nuget packages ASP.NET Core 3.1
  • alignment with templates

issues:
#397

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[x] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

Update to latest Microsoft.Identity.Web C# templates
Update app settings
Update Nuget packages
alignment with templates
# Conflicts:
#	2-WebApp-graph-user/2-2-TokenCache/WebApp-OpenIDConnect-DotNet.csproj
@damienbod
Copy link
Contributor Author

damienbod commented Sep 11, 2020

@jmprieur Updated to 0.4.0-preview. I believe the version in the master is missing the Microsoft.Identity.Web.MicrosoftGraph package. Would you consider merging this?

Copy link
Contributor

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @damienbod

@jmprieur jmprieur merged commit ee35fff into Azure-Samples:master Sep 11, 2020
@jmprieur
Copy link
Contributor

@damienbod : done;
Will you update the other PRs?

@damienbod
Copy link
Contributor Author

@jmprieur thanks for the merge. Yes the PR from me is already updated.

@damienbod damienbod deleted the damienbod/2-2-TokenCache branch September 26, 2020 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants