Skip to content

Added a link to the latest Identity developer's introduction to MS Graph recording #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 20, 2019

Conversation

kalyankrishna1
Copy link
Contributor

Purpose

Added a link to the latest Identity developer's introduction to MS Graph recording

  • ...

Does this introduce a breaking change?

[ ] Yes
[X ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ X] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

@kalyankrishna1 kalyankrishna1 changed the title Kkrishna/updates2019 Added a link to the latest Identity developer's introduction to MS Graph recording Nov 19, 2019
Copy link
Contributor

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Just wondering why remove the proj file?

@@ -1,14 +0,0 @@
<Project DefaultTargets="Build">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmprieur I put it back. This is due to a duplication of this file that we had on GitHub only and I excluded one of them. However excluding one of them on GitHub caused a deletion on your local repo when you pull the first time from master. You just have to ignore that change once and you are good.

@kalyankrishna1 kalyankrishna1 merged commit 1ef46ee into master Nov 20, 2019
@jmprieur jmprieur deleted the kkrishna/updates2019 branch November 25, 2019 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants