Enable redirection of installation output, add arduino_library_location.rb
#92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianfixes
force-pushed
the
2019-01-16_library_location
branch
from
cc3e340 to
6dcc33e
Compare
ianfixes
commented
Jan 16, 2019
lib/arduino_ci/arduino_downloader.rb
Outdated
| @@ -115,15 +119,15 @@ def download | |||
| total_size += size | |||
| needed_dots = (total_size / chunk_size).to_i | |||
| unprinted_dots = needed_dots - dots | |||
| print("." * unprinted_dots) if unprinted_dots > 0 | |||
| @output.puts("." * unprinted_dots) if unprinted_dots > 0 | |||
There was a problem hiding this comment.
this should be @output.print
ianfixes
commented
Jan 16, 2019
lib/arduino_ci/arduino_downloader.rb
Outdated
| @@ -133,7 +137,7 @@ def extract | |||
| batch_size = [1, (zip.size / 100).to_i].max | |||
| dots = 0 | |||
| zip.each do |file| | |||
| print "." if (dots % batch_size).zero? | |||
| @output.puts "." if (dots % batch_size).zero? | |||
There was a problem hiding this comment.
should be @output.print
ianfixes
force-pushed
the
2019-01-16_library_location
branch
from
6dcc33e to
c7b0778
Compare
|
Hello @ianfixes It will be nice if you could publish a release. Kind regards |
ianfixes
changed the title
arduino_library_location.rb
@scls19fr I will get to it, I have been maintaining some other projects |
|
Released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ability to do cross-platform build scripts, ensuring that custom libraries get copied into the correct Arduino library directory.
Highlights from
CHANGELOG.mdArduinoInstallationandArduinoDownloadernow allow console output to optionally be set to anIOobject of choice duringforce_installArduinoInstallation::force_installnow optionally accepts a version stringarduino_library_location.rbscript to print Arduino library location to stdoutIssues Fixed