Skip to content

Make LED_BUILTIN definition available for Arduino Due, Zero and Circuit Playground #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 29, 2022

Conversation

hlovdal
Copy link
Contributor

@hlovdal hlovdal commented Dec 29, 2022

Updates to CHANGELOG.md will trigger conflicts for this branch (led_builtin.m, rebased on top of master) when #338 is completed (or if this is done first, then #338 will get conflicts).

There is an alternative branch led_builtin applied in series with other branches that does not have those conflicts when #338 is completed. Let me know if you rather want that one merged (later).

@ianfixes
Copy link
Collaborator

Can you confirm that the defined value should be 13 for these platforms? If not, can you open an issue for us to look into that later?

@ianfixes ianfixes merged commit a967a67 into Arduino-CI:master Dec 29, 2022
@hlovdal
Copy link
Contributor Author

hlovdal commented Dec 29, 2022

Ok, I'll check (later).

@hlovdal hlovdal deleted the led_builtin.m branch December 30, 2022 20:39
@hlovdal
Copy link
Contributor Author

hlovdal commented Dec 30, 2022

Confirmed. Adding

static_assert(LED_BUILTIN == 13, "not 13");

to main.cpp and compiling with

~/arduino-cli compile --fqbn arduino:avr:circuitplay32u4cat .
~/arduino-cli compile --fqbn adafruit:avr:circuitplay32u4cat .
~/arduino-cli compile --fqbn adafruit:samd:adafruit_circuitplayground_m0 .
~/arduino-cli compile --fqbn arduino:sam:arduino_due_x .
~/arduino-cli compile --fqbn arduino:sam:arduino_due_x_dbg .

all succeeds.

(package install steps from here)

@ianfixes
Copy link
Collaborator

Thanks for checking, I really appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants