Fix CI redux

.gitignore

@@ -7,6 +7,7 @@
 /pkg/
 /spec/reports/
 vendor
+*.gem
 
 # rspec failure tracking
 .rspec_status

.travis.yml

@@ -1,15 +1,16 @@
 sudo: false
 language: ruby
 
-rvm:
+# rvm:
 #  - "2.0.0"
 #  - "2.1.0"
 #  - "2.2.0"
 #  - rbx
- - "2.5.0"
+#  - "2.5.0"
 
 before_install: gem install bundler -v 1.15.4
 script:
    - bundle exec rubocop --version
    - bundle exec rubocop -D .
    - bundle exec rspec
+   - bundle exec ci_system_check.rb

CHANGELOG.md

@@ -6,14 +6,25 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ## [Unreleased]
 ### Added
+- `ArduinoInstallation` class for managing lib / executable paths
+- `DisplayManager` class for managing Xvfb instance if needed
+- `ArduinoCmd` captures and caches preferences
+- `ArduinoCmd` reports on whether a board is installed
+- `ArduinoCmd` sets preferences
+- `ArduinoCmd` installs boards
+- `ArduinoCmd` installs libraries
+- `ArduinoCmd` selects boards (compiler preference)
 
 ### Changed
+- `DisplayManger.with_display` doesn't `disable` if the display was enabled prior to starting the block
 
 ### Deprecated
 
 ### Removed
 
 ### Fixed
+- Built gems are `.gitignore`d
+- Updated gems based on Github's security advisories
 
 ### Security
 

arduino_ci.gemspec

@@ -14,14 +14,17 @@ Gem::Specification.new do |spec|
   spec.description   = spec.description
   spec.homepage      = "http://github.com/ifreecarve/arduino_ci"
 
-  spec.files         =  ['README.md', '.yardopts'] + Dir['lib/**/*.*'].reject { |f| f.match(%r{^(test|spec|features)/}) }
-
   spec.bindir        = "exe"
+  rejection_regex    = %r{^(test|spec|features)/}
+  libfiles           = Dir['lib/**/*.*'].reject { |f| f.match(rejection_regex) }
+  binfiles           = Dir[File.join(spec.bindir, '/**/*.*')].reject { |f| f.match(rejection_regex) }
+  spec.files         =  ['README.md', '.yardopts'] + libfiles + binfiles
+
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
   spec.add_development_dependency "bundler", "~> 1.15"
   spec.add_development_dependency "rspec", "~> 3.0"
-  spec.add_development_dependency 'rubocop', '~> 0', '>= 0.46.0'
-  spec.add_development_dependency 'yard', '~>0.8', '>= 0.8'
+  spec.add_development_dependency 'rubocop', '~>0.49.0'
+  spec.add_development_dependency 'yard', '~>0.9.11'
 end

exe/ci_system_check.rb

@@ -0,0 +1,44 @@
+require 'arduino_ci'
+
+puts "Enabling display with display manager"
+ArduinoCI::DisplayManager::instance.enable
+
+puts "Autlocating Arduino command"
+arduino_cmd = ArduinoCI::ArduinoCmd.autolocate!
+
+board_tests = {
+  "arduino:avr:uno" => true,
+  "eggs:milk:wheat" => false,
+}
+
+got_problem = false
+board_tests.each do |k, v|
+  puts "I expect arduino_cmd.board_installed?(#{k}) to be #{v}"
+  result = arduino_cmd.board_installed?(k)
+  puts "  board_installed?(#{k}) returns #{result}.  expected #{v}"
+  got_problem = true if v != result
+end
+
+urls = [
+  "https://adafruit.github.io/arduino-board-index/package_adafruit_index.json",
+  "http://arduino.esp8266.com/stable/package_esp8266com_index.json"
+]
+
+puts "Setting additional URLs"
+got_problem = true unless arduino_cmd.set_pref("boardsmanager.additional.urls", urls.join(","))
+
+puts "Installing arduino:sam"
+got_problem = true unless arduino_cmd.install_board("arduino:sam")
+puts "Installing USBHost"
+got_problem = true unless arduino_cmd.install_library("USBHost")
+puts "checking that library is indexed"
+got_problem = true unless arduino_cmd.library_is_indexed
+puts "setting compiler warning level"
+got_problem = true unless arduino_cmd.set_pref("compiler.warning_level", "all")
+puts "use board! (install board)"
+got_problem = true unless arduino_cmd.use_board!("arduino:samd:zero")
+puts "verify that board has been installed"
+got_problem = true unless arduino_cmd.board_installed?("arduino:samd:zero")
+
+abort if got_problem
+exit(0)

lib/arduino_ci.rb

@@ -1,124 +1,8 @@
 require "arduino_ci/version"
-
-require 'singleton'
-
-# Cross-platform way of finding an executable in the $PATH.
-# via https://stackoverflow.com/a/5471032/2063546
-#   which('ruby') #=> /usr/bin/ruby
-def which(cmd)
-  exts = ENV['PATHEXT'] ? ENV['PATHEXT'].split(';') : ['']
-  ENV['PATH'].split(File::PATH_SEPARATOR).each do |path|
-    exts.each do |ext|
-      exe = File.join(path, "#{cmd}#{ext}")
-      return exe if File.executable?(exe) && !File.directory?(exe)
-    end
-  end
-  nil
-end
+require "arduino_ci/arduino_cmd"
 
 # ArduinoCI contains classes for automated testing of Arduino code on the command line
 # @author Ian Katz <[email protected]>
 module ArduinoCI
 
-  # Wrap the Arduino executable.  This requires, in some cases, a faked display.
-  class ArduinoCmd
-
-    # create as many ArduinoCmds as you like, but we need one and only one display manager
-    class DisplayMgr
-      include Singleton
-      attr_reader :enabled
-
-      def initialize
-        @existing = existing_display?
-        @enabled = false
-        @pid = nil
-      end
-
-      # attempt to determine if the machine is running a graphical display (i.e. not Travis)
-      def existing_display?
-        return true if RUBY_PLATFORM.include? "darwin"
-        return true if ENV["DISPLAY"].nil?
-        return true if ENV["DISPLAY"].include? ":"
-        false
-      end
-
-      # enable a virtual display
-      def enable
-        return @enabled = true if @existing   # silent no-op if built in display
-        return unless @pid.nil?
-
-        @enabled = true
-        @pid = fork do
-          puts "Forking Xvfb"
-          system("Xvfb", ":1", "-ac", "-screen", "0", "1280x1024x16")
-          puts "Xvfb unexpectedly quit!"
-        end
-        sleep(3)  # TODO: test a connection to the X server?
-      end
-
-      # disable the virtual display
-      def disable
-        return @enabled = false if @existing  # silent no-op if built in display
-        return if @pid.nil?
-
-        begin
-          Process.kill 9, @pid
-        ensure
-          Process.wait @pid
-          @pid = nil
-        end
-        puts "Xvfb killed"
-      end
-
-      # Enable a virtual display for the duration of the given block
-      def with_display
-        enable
-        begin
-          yield environment
-        ensure
-          disable
-        end
-      end
-
-      def environment
-        return nil unless @existing || @enabled
-        return {} if @existing
-        { DISPLAY => ":1.0" }
-      end
-
-      # On finalize, ensure child process is ended
-      def self.finalize
-        disable
-      end
-    end
-
-    class << self
-      protected :new
-
-      # attempt to find a workable Arduino executable across platforms
-      def guess_executable_location
-        osx_place = "/Applications/Arduino.app/Contents/MacOS/Arduino"
-        places = {
-          "arduino" => !which("arduino").nil?,
-          osx_place => (File.exist? osx_place),
-        }
-        places.each { |k, v| return k if v }
-        nil
-      end
-
-      def autolocate
-        ret = new
-        ret.path = guess_executable_location
-        ret
-      end
-    end
-
-    attr_accessor :path
-
-    def initialize
-      @display_mgr = DisplayMgr::instance
-    end
-
-  end
-
 end