-
Notifications
You must be signed in to change notification settings - Fork 34
Added arduino nano every config #287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Please add a changelog entry like "Added Regarding the test failures, I think the unit tests should be updated to include your platform... If you're not comfortable fixing the unit test yourself, just edit this PR to be against the |
My bad for forgetting to add a changelog entry, sorry... 🤦 |
@ianfixes, I'm looking at open PRs and not sure what you are suggesting. It looks like all tests pass (or passed a year ago!). Are you suggesting adding |
Ouch, time has gone by quickly. The comment I made was in regard to this line being deleted: 0708704#diff-92a4a126d74841479f7a742fb740ce8edf0d48218b8d11adf405e92d860dda93L197 I think this PR should not go through unless that line is re-added and the resulting test failures addressed. |
Integrated into #334 and seems to work in that context |
Added platform configuration for the arduino nano every in default.yaml.
Check this issue for more details.
Highlights from
CHANGELOG.md
nano_every
platform to representarduino:megaavr
architecture