Skip to content

Added arduino nano every config #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

midasgossye
Copy link
Contributor

@midasgossye midasgossye commented Feb 16, 2021

Added platform configuration for the arduino nano every in default.yaml.
Check this issue for more details.

Highlights from CHANGELOG.md

  • Added nano_every platform to represent arduino:megaavr architecture
  • See CHANGELOG.md for more

@ianfixes
Copy link
Collaborator

Please add a changelog entry like "Added nano_every platform to represent the arduino:megaavr architecture"

Regarding the test failures, I think the unit tests should be updated to include your platform... If you're not comfortable fixing the unit test yourself, just edit this PR to be against the tdd branch and I'll merge that in even when failing.

@midasgossye midasgossye changed the base branch from master to tdd February 16, 2021 14:21
@midasgossye
Copy link
Contributor Author

My bad for forgetting to add a changelog entry, sorry... 🤦
Should be added now. I tried to look into changing the unit tests but I'm afraid I will do more harm than good since I'm not familiar with Ruby 😅
I changed the base branch form master to tdd like you suggested.

@ianfixes ianfixes changed the base branch from tdd to master February 16, 2021 14:28
@ianfixes ianfixes changed the base branch from master to tdd February 16, 2021 14:29
@jgfoster
Copy link
Member

Regarding the test failures, I think the unit tests should be updated to include your platform.

@ianfixes, I'm looking at open PRs and not sure what you are suggesting. It looks like all tests pass (or passed a year ago!). Are you suggesting adding nano to unittest/platforms in SampleProjects/TestSomething/.arduino-ci.yml? It seems that the existing list is intentionally short and does not include all possible platforms so I'm not sure how the existing list was selected. Thanks!

@jgfoster jgfoster changed the base branch from tdd to master February 13, 2022 18:53
@ianfixes
Copy link
Collaborator

Ouch, time has gone by quickly.

The comment I made was in regard to this line being deleted:

0708704#diff-92a4a126d74841479f7a742fb740ce8edf0d48218b8d11adf405e92d860dda93L197

I think this PR should not go through unless that line is re-added and the resulting test failures addressed.

@ianfixes
Copy link
Collaborator

Integrated into #334 and seems to work in that context

@ianfixes ianfixes closed this Dec 17, 2022
@ianfixes
Copy link
Collaborator

This has merged as part of #334 and was released in v1.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants