Fix library parse error if there is an extra blank line in library_properties.rb

CHANGELOG.md

@@ -15,6 +15,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 ### Removed
 
 ### Fixed
+- Parse error in `library_properties.rb`
+- Missing include of `IPAddress.h` in `Client.h`
 
 ### Security
 

SampleProjects/NetworkLib/test/client.cpp

@@ -0,0 +1,7 @@
+#include <ArduinoUnitTests.h>
+// test for including <Client.h> without <Arduino.h>
+#include <Client.h>
+
+unittest(test) { assertTrue(true); }
+
+unittest_main()

SampleProjects/TestSomething/library.properties

@@ -3,8 +3,9 @@ version=0.1.0
 author=Ian Katz <[email protected]>
 maintainer=Ian Katz <[email protected]>
 sentence=Arduino CI unit test example
-paragraph=A skeleton library demonstrating CI and unit tests
+paragraph=A skeleton library demonstrating CI and unit tests. NOTE THAT THE EXTRA BLANK LINE AT THE END OF THIS FILE IS INTENTIONAL TO TEST A PARSE ERROR (#224)!
 category=Other
 url=https://github.com/Arduino-CI/arduino_ci/SampleProjects/TestSomething
 architectures=avr,esp8266
 includes=test-something.h
+

cpp/arduino/Client.h

@@ -1,6 +1,7 @@
 #pragma once
 
 #include <Stream.h>
+#include <IPAddress.h>
 
 class Client : public Stream {
 public:

lib/arduino_ci/library_properties.rb

@@ -12,7 +12,7 @@ class LibraryProperties
     def initialize(path)
       @fields = {}
       File.foreach(path) do |line|
-        parts = line.split("=", 2)
+        parts = line.strip.split("=", 2)  # check for empty on next line fails if there is a newline (#224)
         @fields[parts[0]] = parts[1].chomp unless parts.empty?
       end
     end