Skip to content

Add git attributes to force only lf line endings #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2020

Conversation

prestoncarman
Copy link
Contributor

In setting up GitHub Actions, I noticed that bundle exec rubocop -D . was throwing 25 offense for something like this:

Gemfile:1:1: C: Layout/EndOfLine: Carriage return character detected.
source "https://rubygems.org" ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

I added a .gitattributes file to force lf line endings to match the rubocop settings in .rubocop.yml

@prestoncarman
Copy link
Contributor Author

The issue will show up once #200 has been included. Check out the log from https://github.com/prestoncarman/arduino_ci/runs/1404340103?check_suite_focus=true. I guess this has to do with either Windows version or configuration settings for Windows CI test.

@ianfixes ianfixes merged commit f32ba70 into Arduino-CI:master Nov 16, 2020
@ianfixes
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants