-
Notifications
You must be signed in to change notification settings - Fork 34
Add support for EEPROM #184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add initial support for EEPROM
… less file changed).
Add Mock Support for EEPROM
Merge `master` into `ttd` to reduce diffs
Add tests for EEPROM
What information should I put into |
Actually it is fair for you to say that we need to update the documentation! How that looks is open for discussion and advice. From the beginning (only a few weeks ago) I've been unsure on how to fit in new mocks. Since the EEPROM functionality doesn't involve pins, I don't see the direct tie-in to Shall I put in a PR with a paragraph describing how to use EEPROM? |
Apologies for the delay. It looks like the unit tests are all there, so all that I think remains is a short paragraph in |
Add documentation for EEPROM
I'll smooth over the merge conflicts here in a bit |
cpp/arduino/EEPROM.h
Outdated
This library is free software; you can redistribute it and/or | ||
modify it under the terms of the GNU Lesser General Public | ||
License as published by the Free Software Foundation; either | ||
version 2.1 of the License, or (at your option) any later version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably reconsider adding this directly since its license is inconsistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm really out of my depth with regard to the terms of all the different licenses, and really can't offer advice one way or another. I have no idea whether your own rewrite counts as some "derivative" in the way the licenses are written.
I think as long as we're doing our best and intend to respond to any legal complaints -- fixing the license as appropriate -- (which I do intend to do) then I'm not sure what else it would take to move forward. In any case, if we keep the file let's keep the license and it can all get sorted out later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As owner of the project, you certainly have the last word on this. But (did you sense a "but" coming?), the difference between the GNU license and your Apache license is night and day (with slight exaggeration, think Catholics and Protestants in 16th, 17th, and 18th century Europe, or Antifa vs. Proud Boys today). While I can't promise that my replacement would withstand a legal challenge, I'm pretty confident that it would be better to leave out the GNU reference. Other than the file name and the published API, I made an effort to write the code from scratch and think that the risk is extremely small. By leaving in the GNU license, you risk attaching GNU to my code, and then you would need another rewrite.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw your rewrite after adding my comment, and I think your rewrite satisfies
I've squashed this into #183 |
Fixes #166. Also add testing to demonstrate use.