Skip to content

Improve boilerplate for test code #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ianfixes opened this issue Jan 25, 2018 · 0 comments
Closed

Improve boilerplate for test code #9

ianfixes opened this issue Jan 25, 2018 · 0 comments
Labels
unittest libs The assert / assure / unittest reporting apparatus is affected

Comments

@ianfixes
Copy link
Collaborator

Seems like I should have a macro to replace

int main(int argc, char *argv[]) {
  return Test::run_and_report(argc, argv);
}

But I don't know what it should be, or if I should do it at all

Pros:

  • Gives Ruby full control over the executables, enables tighter coupling and more seamless transfer of settings there without intervention on the part of the Arduino library maintainer.

Cons:

  • What should the macro be, such that when you look at a test file you know it's a "normal" CPP file?
@ianfixes ianfixes added the unittest libs The assert / assure / unittest reporting apparatus is affected label Jan 25, 2018
@ianfixes ianfixes mentioned this issue Jan 25, 2018
Merged
jgfoster pushed a commit that referenced this issue Oct 4, 2021
The test is now more explicit about looking at the values expected. B…
23c3670 
…efore the fix to Client.h we get the following error:

```
# Subtest: Client_copy_constructor
    ok 1 - assertEqual "1" == *(c1.mGodmodeDataIn)
    ok 2 - assertEqual "2" == *(c2.mGodmodeDataIn)
    not ok 3 - assertNotEqual c1.mGodmodeDataIn != c2.mGodmodeDataIn
      ---
      operator: !=
      unwanted: 0x603000007750
      actual: 0x603000007750
      at:
        file: /Users/jfoster/Documents/Arduino/libraries/TestSomething/test/clientServer.cpp
        line: 32
      ...
    ok 4 - assertEqual "1" == *(c1.mGodmodeDataIn)
    ok 5 - assertEqual "1" == *(c2.mGodmodeDataIn)
    not ok 6 - assertEqual "11" == *(c1.mGodmodeDataIn)
      ---
      operator: ==
      expected: 11
      actual: 112
      at:
        file: /Users/jfoster/Documents/Arduino/libraries/TestSomething/test/clientServer.cpp
        line: 37
      ...
    not ok 7 - assertEqual "12" == *(c2.mGodmodeDataIn)
      ---
      operator: ==
      expected: 12
      actual: 112
      at:
        file: /Users/jfoster/Documents/Arduino/libraries/TestSomething/test/clientServer.cpp
        line: 38
      ...
AddressSanitizer:DEADLYSIGNAL
=================================================================
==16588==ERROR: AddressSanitizer: SEGV on unknown address (pc 0x0001076e5918 bp 0x7ffee8564290 sp 0x7ffee8564260 T0)
==16588==The signal is caused by a READ memory access.
==16588==Hint: this fault was caused by a dereference of a high value address (see register values below).  Dissassemble the provided pc to learn which register was used.
    #0 0x1076e5918 in __asan::Allocator::Deallocate(void*, unsigned long, unsigned long, __sanitizer::BufferedStackTrace*, __asan::AllocType)+0x48 (libclang_rt.asan_osx_dynamic.dylib:x86_64+0x5918)
    #1 0x107733125 in wrap__ZdlPv+0xe5 (libclang_rt.asan_osx_dynamic.dylib:x86_64+0x53125)
    #2 0x10769d528 in String::~String() WString.h:65
    #3 0x10769d228 in String::~String() WString.h:65
    #4 0x1076a6856 in Client::~Client() Client.h:35
    #5 0x1076a2f48 in Client::~Client() Client.h:33
    #6 0x1076a3473 in test_Client_copy_constructor::task() clientServer.cpp:39
    #7 0x1076a8390 in Test::test() ArduinoUnitTests.h:205
    #8 0x1076a7f2d in Test::run(Test::ReporterTAP*) ArduinoUnitTests.h:176
    #9 0x1076a5713 in Test::run_and_report(int, char**) ArduinoUnitTests.h:195
    #10 0x1076a5658 in main clientServer.cpp:110
    #11 0x7fff70a26cc8 in start+0x0 (libdyld.dylib:x86_64+0x1acc8)

==16588==Register values:
rax = 0x0000000000000002  rbx = 0xbebebebebebebebe  rcx = 0x0000000000000003  rdx = 0x0000000000000000
rdi = 0xbebebebebebebebe  rsi = 0xbebebebebebebebe  rbp = 0x00007ffee8564290  rsp = 0x00007ffee8564260
 r8 = 0x00007ffee85642a0   r9 = 0x0000000000000002  r10 = 0xffffffffffffffff  r11 = 0x00000fffffffffff
r12 = 0x0000000000000002  r13 = 0x0000000000000000  r14 = 0x00007ffee85642a0  r15 = 0x0000000107780d40
AddressSanitizer can not provide additional info.
SUMMARY: AddressSanitizer: SEGV (libclang_rt.asan_osx_dynamic.dylib:x86_64+0x5918) in __asan::Allocator::Deallocate(void*, unsigned long, unsigned long, __sanitizer::BufferedStackTrace*, __asan::AllocType)+0x48
==16588==ABORTING
...Unit testing clientServer.cpp with g++ for uno                              ✗
```

After the fix we get the following:

```
# Subtest: Client_copy_constructor
    ok 1 - assertEqual "1" == *(c1.mGodmodeDataIn)
    ok 2 - assertEqual "2" == *(c2.mGodmodeDataIn)
    ok 3 - assertNotEqual c1.mGodmodeDataIn != c2.mGodmodeDataIn
    ok 4 - assertEqual "1" == *(c1.mGodmodeDataIn)
    ok 5 - assertEqual "1" == *(c2.mGodmodeDataIn)
    ok 6 - assertEqual "11" == *(c1.mGodmodeDataIn)
    ok 7 - assertEqual "12" == *(c2.mGodmodeDataIn)
    ok 8 - True true
    1..8
ok 2 - Client_copy_constructor
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
unittest libs The assert / assure / unittest reporting apparatus is affected
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ianfixes