Skip to content

Improve factorization of "unused space" #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ianfixes opened this issue Dec 12, 2022 · 0 comments · Fixed by #334
Closed

Improve factorization of "unused space" #335

ianfixes opened this issue Dec 12, 2022 · 0 comments · Fixed by #334
Labels
enhancement New feature or request rubygem Ruby code is affected

Comments

@ianfixes
Copy link
Collaborator

Use more sophisticated logic to calculate free space remaining

Regarding code contributed by @jgfoster in #308

          output = @backend.last_msg
          puts output
          i = output.index("leaving")
          free_space = output[i + 8..-1].to_i

We need to do the following:

  1. Move the space calculation into the backend
  2. Specify the units (Bytes, kB, etc) in the messaging for the CLI option
  3. Use a more sophisticated regex match to extract the number value, and possibly add unit testing for that
  4. Report space requirements as a separate check from the compilation itself
@ianfixes ianfixes added enhancement New feature or request rubygem Ruby code is affected labels Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request rubygem Ruby code is affected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant