Skip to content

Arduino-cli 0.14 has deprecated '--dry-run' flag since it is default behaviour since this version #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
s-t-a-n opened this issue Jan 28, 2021 · 2 comments · Fixed by #334
Labels
backend enhancement New feature or request

Comments

@s-t-a-n
Copy link

s-t-a-n commented Jan 28, 2021

The latest arduino-cli version (0.14) no longer supports the '--dry-run' flag since 'Arduino CLI now defaults to the --dry-run behavior, so there is no longer any need for that flag (source).

I am not that familiar with Ruby, but I have tested removing --dry-run from lib/arduino_ci/arduino_backend.rb and this works fine for 0.14. On 0.13 this does create build/ directory with binaries.

Add version sensing for arduino-cli to arduino_backend.rb or maybe remove '--dry-run' and add build directory to gitignore ?

@ianfixes ianfixes added enhancement New feature or request rubygem Ruby code is affected backend and removed rubygem Ruby code is affected labels Jan 29, 2021
@ianfixes ianfixes added this to the arduino-cli 0.14 milestone Jan 29, 2021
@ianfixes
Copy link
Collaborator

ianfixes commented Jan 29, 2021

Hey, thanks for reporting this! I think this is more generally a reminder that I should be upgrading to 0.14 of the arduino-cli backend. Let me set up that list and add this to it.

note to self: arduino/arduino-cli#1051

@matburnham
Copy link

matburnham commented Sep 28, 2022

I've also applied the following bodge patch to /var/lib/gems/2.7.0/gems/arduino_ci-1.3.0/lib/arduino_ci

--- arduino_backend.rb.orig     2022-09-28 22:09:14.031508917 +0100
+++ arduino_backend.rb  2022-09-28 22:09:29.471458900 +0100
@@ -163,7 +163,7 @@
         @last_msg = "Can't compile Sketch at nonexistent path '#{path}'!"
         return false
       end
-      ret = run_and_capture("compile", "--fqbn", boardname, "--warnings", "all", "--dry-run", path.to_s)
+      ret = run_and_capture("compile", "--fqbn", boardname, "--warnings", "all", path.to_s)
       ret[:success]
     end

arduino-cli is now on version 0.27.1 and well deprecating --dry-run so it would be great to have PR #323 merged and released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants