Skip to content

organize for dist as pypi package #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 13, 2021

Conversation

rmorshea
Copy link

No description provided.

@rmorshea
Copy link
Author

rmorshea commented Jun 13, 2021

@Archmonger so I think this is mostly done with the exception of tests, which will have to be written using selenium (since IDOM relies on Javascript). See this section of the Django docs describing how to using Selenium with Django.

However, now that we've got this fully functional test_app, I'm wondering whether we should just distribute that app. The main thing to consider is how a user who installed django_idom should go about customizing where IDOM will render on the page, but beyond that, it'd greatly simplify how people would use django_idom - especially because django allows you to heavily curate how people will develop with it.

@Archmonger
Copy link
Owner

Archmonger commented Jun 13, 2021

I think there might be a line between curation and flexibility we might wanna consider. You'll never know what kind of hacky implementation a dev wants to push through.
But I do think it's worth a discussion.

@Archmonger Archmonger merged commit aa5b5e1 into Archmonger:main Jun 13, 2021
Archmonger pushed a commit that referenced this pull request Jul 22, 2021
initial implementation for django-idom

at some point we should push the work in test_app back into django_idom
so that it's easier to integrate with
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants