Skip to content

Feat/choropleth map #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 6, 2023
Merged

Feat/choropleth map #4

merged 6 commits into from
Jan 6, 2023

Conversation

AlvinFok
Copy link
Owner

@AlvinFok AlvinFok commented Jan 3, 2023

Map show the winner party color
Screenshot 2023-01-03 at 11 56 59 AM

@AlvinFok AlvinFok requested a review from joejoe2 January 3, 2023 03:57
@joejoe2
Copy link
Collaborator

joejoe2 commented Jan 3, 2023

How can we apply map to the legislator data ?

@joejoe2
Copy link
Collaborator

joejoe2 commented Jan 5, 2023

I made it compatible with legislator-at-large and add some todos in code. @AlvinFok please check it.

@AlvinFok
Copy link
Owner Author

AlvinFok commented Jan 5, 2023

OK. I will check it today

@AlvinFok
Copy link
Owner Author

AlvinFok commented Jan 5, 2023

I add the year selector plz check

@joejoe2
Copy link
Collaborator

joejoe2 commented Jan 5, 2023

Title should be changed (something like: majorities in Taiwan cities of 2016/2020 president election). And add legends to map to show which color represent which candidate.

@AlvinFok
Copy link
Owner Author

AlvinFok commented Jan 5, 2023

Title should be changed (something like: majorities in Taiwan cities of 2016/2020 president election). And add legends to map to show which color represent which candidate.

categorical choropleth seems unavailable with js plotly
plotly/plotly.js#3468

@joejoe2
Copy link
Collaborator

joejoe2 commented Jan 6, 2023

legends added.

@AlvinFok AlvinFok merged commit 799ee30 into main Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants