Add path information to errors #163
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this PR doesn't make sense anymore. #153 also fixed that problem. BTW, @JamesMessinger, I've seen tests are failing for Windows. Let me know if I can help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! This PR adds extra information to the errors triggered when dereferencing and resolving external references. The reason I'm adding this info is that in the AsyncAPI playground, I want to find line and column of the failing $ref and with the current error I'd have to parse the error message, which is not ideal.
I suspect this info could be added to other errors too so feel free to point me out to the other places and I'll be happy to add them on this PR.
Thanks a lot for the excellent tool 🙌