Skip to content

Commit fb75c0a

Browse files
committed
some improvements
1 parent 586d578 commit fb75c0a

File tree

5 files changed

+4
-2
lines changed

5 files changed

+4
-2
lines changed

packages/core-js/internals/array-sort.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
'use strict';
1+
// TODO: use something more complex like timsort?
22
var floor = Math.floor;
33

44
var mergeSort = function (array, comparefn) {

packages/core-js/modules/es.array.sort.js

-1
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,6 @@ $({ target: 'Array', proto: true, forced: FORCED }, {
8989
if (index in array) items.push(array[index]);
9090
}
9191

92-
// TODO: use something more complex like timsort?
9392
items = internalSort(items, getSortCompare(comparefn));
9493
itemsLength = items.length;
9594
index = 0;

tests/pure/es.array.sort.js

+1
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ QUnit.test('Array#sort', assert => {
1010

1111
assert.deepEqual(sort([1, 3, 2]), [1, 2, 3], '#1');
1212
assert.deepEqual(sort([1, 3, 2, 11]), [1, 11, 2, 3], '#2');
13+
assert.deepEqual(sort([1, -1, 3, NaN, 2, 0, 11, -0]), [-1, 0, -0, 1, 11, 2, 3, NaN], '#3');
1314

1415
let array = Array(5);
1516
array[0] = 1;

tests/tests/es.array.sort.js

+1
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ QUnit.test('Array#sort', assert => {
1010

1111
assert.deepEqual([1, 3, 2].sort(), [1, 2, 3], '#1');
1212
assert.deepEqual([1, 3, 2, 11].sort(), [1, 11, 2, 3], '#2');
13+
assert.deepEqual([1, -1, 3, NaN, 2, 0, 11, -0].sort(), [-1, 0, -0, 1, 11, 2, 3, NaN], '#1');
1314

1415
let array = Array(5);
1516
array[0] = 1;

tests/tests/es.typed-array.sort.js

+1
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ if (DESCRIPTORS) QUnit.test('%TypedArrayPrototype%.sort', assert => {
1111
assert.looksNative(sort, `${ name }::sort looks native`);
1212

1313
if (name.indexOf('Float') === 0) {
14+
assert.deepEqual(new TypedArray([1, -1, 3, NaN, 2, 0, 11, -0]).sort(), new TypedArray([-1, -0, 0, 1, 2, 3, 11, NaN]), '#1');
1415
assert.ok(1 / new TypedArray([0, -0]).sort()[0] < 0, '-0');
1516
assert.deepEqual(new TypedArray([NaN, 1, NaN]).sort(), new TypedArray([1, NaN, NaN]), 'NaN');
1617
}

0 commit comments

Comments
 (0)