Skip to content

Commit 9c3a0d8

Browse files
committed
use konan instead of detective since we need ESM support
1 parent 25f09dd commit 9c3a0d8

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@
3333
"core-js-compat": "file:./packages/core-js-compat",
3434
"core-js-pure": "file:./packages/core-js-pure",
3535
"david": "^12.0.0",
36-
"detective": "^5.2.0",
3736
"electron-to-chromium": "^1.3.795",
3837
"es-observable": "git+https://github.com/tc39/proposal-observable.git#d3404f06bc70c7c578a5047dfb3dc813730e3319",
3938
"eslint": "^7.32.0",
@@ -52,6 +51,7 @@
5251
"karma-chrome-launcher": "^3.1.0",
5352
"karma-phantomjs-launcher": "~1.0.4",
5453
"karma-qunit": "^4.1.2",
54+
"konan": "^2.1.1",
5555
"lerna": "^4.0.0",
5656
"moon-unit": "0.2.2",
5757
"npm": "^7.20.3",

scripts/build-compat-entries.mjs

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
import detective from 'detective';
21
import { globby } from 'globby';
2+
import konan from 'konan';
33
import { modules } from 'core-js-compat/src/data.mjs';
44
import helpers from 'core-js-compat/helpers.js';
55

@@ -14,7 +14,7 @@ async function getModulesForEntryPoint(path, parent) {
1414
if (!await fs.pathExists(entry)) return [];
1515

1616
const file = await fs.readFile(entry);
17-
const result = await Promise.all(detective(file).map(dependency => {
17+
const result = await Promise.all(konan(String(file)).strings.map(dependency => {
1818
return getModulesForEntryPoint(dependency, entry);
1919
}));
2020

scripts/check-unused-modules.mjs

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/* eslint-disable no-console -- output */
2-
import detective from 'detective';
32
import { globby } from 'globby';
3+
import konan from 'konan';
44
import { modules } from 'core-js-compat/src/data.mjs';
55

66
async function jsModulesFrom(path) {
@@ -26,7 +26,7 @@ const internalModules = await jsModulesFrom('packages/core-js/internals');
2626
const allModules = await globby('packages/core-js?(-pure)/**/*.js');
2727

2828
await Promise.all(allModules.map(async path => {
29-
for (const dependency of detective(await fs.readFile(path))) {
29+
for (const dependency of konan(String(await fs.readFile(path))).strings) {
3030
internalModules.delete(dependency.match(/\/internals\/([^/]+)$/)?.[1]);
3131
}
3232
}));

0 commit comments

Comments
 (0)