Skip to content

Commit 5c40bd2

Browse files
committed
1 parent b924dc8 commit 5c40bd2

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

src/components/SkillsList/index.jsx

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@ const SkillsList = ({requiredSkills, skills, limit = 3 }) => {
1616
const skillsToShow = skills.slice(0, limit);
1717
const skillsToHide = skills.slice(limit);
1818

19-
// if has requiredSkills, show two columns, eles show only one column
20-
const showMatches = !!requiredSkills
2119
const [isOpen, setIsOpen] = useState(false);
2220
const [referenceElement, setReferenceElement] = useState(null);
2321
const [popperElement, setPopperElement] = useState(null);
@@ -106,12 +104,11 @@ const SkillsList = ({requiredSkills, skills, limit = 3 }) => {
106104
<ul styleName="skills-list">
107105
{requiredSkills.map((skill) => (
108106
<li key={skill.id}>
109-
{showMatches &&
110-
(_.find(skills, { id: skill.id }) ? (
107+
{_.find(skills, { id: skill.id }) ? (
111108
<IconCheck />
112109
) : (
113110
<IconCross />
114-
))}{" "}
111+
)}{" "}
115112
{skill.name}
116113
</li>
117114
))}
@@ -120,7 +117,7 @@ const SkillsList = ({requiredSkills, skills, limit = 3 }) => {
120117
)}
121118
{otherSkills && (
122119
<div styleName="skills-section">
123-
<div styleName="skills-title">{showMatches ? 'Other User Skills': 'Required Skills'}</div>
120+
<div styleName="skills-title">{!!requiredSkills ? 'Other User Skills': 'Required Skills'}</div>
124121
<ul styleName="skills-list">
125122
{otherSkills.map((skill) => (
126123
<li key={skill.id}>{skill.name}</li>

0 commit comments

Comments
 (0)