fix sending interview confirmation email

Author: maxceem

scripts/demo-email-notifications/index.js

@@ -98,7 +98,7 @@ async function initConsumer () {
           if (message.payload.notifications) {
             _.forEach(_.filter(message.payload.notifications, ['serviceId', 'email']), (notification) => {
               const email = templateFileMap[notification.details.sendgridTemplateId](notification.details.data)
-              fs.writeFileSync(`./out/${notification.details.data.subject}-${Date.now()}.html`, email)
+              fs.writeFileSync(`./out/${notification.details.data.subject.replace(/[^a-z0-9 ]/gi, '_')}-${Date.now()}.html`, email)
             })
             for (const notification of _.filter(message.payload.notifications, ['serviceId', 'slack'])) {
               if (process.env.SLACK_WEBHOOK_URL) {

src/services/InterviewService.js

@@ -386,6 +386,7 @@ requestInterview.schema = Joi.object().keys({
  * @returns {Object} updated interview
  */
 async function partiallyUpdateInterview (currentUser, interview, data) {
+  const oldInterviewValue = interview.toJSON()
   // only status can be updated for Completed interviews
   if (interview.status === InterviewConstants.Status.Completed) {
     const updatedFields = _.keys(data)
@@ -434,7 +435,7 @@ async function partiallyUpdateInterview (currentUser, interview, data) {
     // if reaches here, it's not one of the common errors handled in `handleSequelizeError`
     throw err
   }
-  await helper.postEvent(config.TAAS_INTERVIEW_UPDATE_TOPIC, entity, { oldValue: interview.toJSON() })
+  await helper.postEvent(config.TAAS_INTERVIEW_UPDATE_TOPIC, entity, { oldValue: oldInterviewValue })
   return entity
 }