Skip to content

Commit 94f9e7c

Browse files
edwhuang23yehoshuadimarsky
authored andcommitted
BUG/TST/DOC: added finalize to melt, GH28283 (pandas-dev#46648)
1 parent 18c98d6 commit 94f9e7c

File tree

3 files changed

+6
-8
lines changed

3 files changed

+6
-8
lines changed

doc/source/whatsnew/v1.5.0.rst

+1
Original file line numberDiff line numberDiff line change
@@ -625,6 +625,7 @@ Styler
625625

626626
Metadata
627627
^^^^^^^^
628+
- Fixed metadata propagation in :meth:`DataFrame.melt` (:issue:`28283`)
628629
- Fixed metadata propagation in :meth:`DataFrame.explode` (:issue:`28283`)
629630
-
630631

pandas/core/frame.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -8717,7 +8717,7 @@ def melt(
87178717
value_name=value_name,
87188718
col_level=col_level,
87198719
ignore_index=ignore_index,
8720-
)
8720+
).__finalize__(self, method="melt")
87218721

87228722
# ----------------------------------------------------------------------
87238723
# Time series-related

pandas/tests/generic/test_finalize.py

+4-7
Original file line numberDiff line numberDiff line change
@@ -156,13 +156,10 @@
156156
(pd.DataFrame, frame_data, operator.methodcaller("stack")),
157157
(pd.DataFrame, frame_data, operator.methodcaller("explode", "A")),
158158
(pd.DataFrame, frame_mi_data, operator.methodcaller("unstack")),
159-
pytest.param(
160-
(
161-
pd.DataFrame,
162-
({"A": ["a", "b", "c"], "B": [1, 3, 5], "C": [2, 4, 6]},),
163-
operator.methodcaller("melt", id_vars=["A"], value_vars=["B"]),
164-
),
165-
marks=not_implemented_mark,
159+
(
160+
pd.DataFrame,
161+
({"A": ["a", "b", "c"], "B": [1, 3, 5], "C": [2, 4, 6]},),
162+
operator.methodcaller("melt", id_vars=["A"], value_vars=["B"]),
166163
),
167164
pytest.param(
168165
(pd.DataFrame, frame_data, operator.methodcaller("applymap", lambda x: x))

0 commit comments

Comments
 (0)