BUG: read_excel loading some xlsx ints as floats (pandas-dev#47121)

* Reintoduce integer conversion when reading xlsx

* whats new 1.4.3

Co-authored-by: Jeff Reback <[email protected]>

Author: 2 people

doc/source/whatsnew/v1.4.3.rst

@@ -24,6 +24,7 @@ Fixed regressions
 - Fixed regression in :func:`read_csv` with ``index_col=False`` identifying first row as index names when ``header=None`` (:issue:`46955`)
 - Fixed regression in :meth:`.DataFrameGroupBy.agg` when used with list-likes or dict-likes and ``axis=1`` that would give incorrect results; now raises ``NotImplementedError`` (:issue:`46995`)
 - Fixed regression in :meth:`DataFrame.resample` and :meth:`DataFrame.rolling` when used with list-likes or dict-likes and ``axis=1`` that would raise an unintuitive error message; now raises ``NotImplementedError`` (:issue:`46904`)
+- Fixed regression in :func:`read_excel` returning ints as floats on certain input sheets (:issue:`46988`)
 - Fixed regression in :meth:`DataFrame.shift` when ``axis`` is ``columns`` and ``fill_value`` is absent, ``freq`` is ignored (:issue:`47039`)
 
 .. ---------------------------------------------------------------------------

pandas/io/excel/_openpyxl.py

@@ -583,8 +583,14 @@ def _convert_cell(self, cell, convert_float: bool) -> Scalar:
             return ""  # compat with xlrd
         elif cell.data_type == TYPE_ERROR:
             return np.nan
-        elif not convert_float and cell.data_type == TYPE_NUMERIC:
-            return float(cell.value)
+        elif cell.data_type == TYPE_NUMERIC:
+            # GH5394, GH46988
+            if convert_float:
+                val = int(cell.value)
+                if val == cell.value:
+                    return val
+            else:
+                return float(cell.value)
 
         return cell.value
 

pandas/tests/io/data/excel/ints_spelled_with_decimals.xlsx

@@ -388,3 +388,11 @@ def test_book_and_sheets_consistent(ext):
             assert writer.sheets == {}
             sheet = writer.book.create_sheet("test_name", 0)
             assert writer.sheets == {"test_name": sheet}
+
+
+def test_ints_spelled_with_decimals(datapath, ext):
+    # GH 46988 - openpyxl returns this sheet with floats
+    path = datapath("io", "data", "excel", f"ints_spelled_with_decimals{ext}")
+    result = pd.read_excel(path)
+    expected = DataFrame(range(2, 12), columns=[1])
+    tm.assert_frame_equal(result, expected)